From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id D69713858C2F for ; Fri, 23 Jun 2023 20:28:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D69713858C2F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id D7B4C1003A119 for ; Fri, 23 Jun 2023 20:28:06 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id CnO2qyoyaxKeeCnO2qf055; Fri, 23 Jun 2023 20:28:06 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NvUUz+RJ c=1 sm=1 tr=0 ts=64960056 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=of4jigFt-DYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=hFdyMEb_xMnH93cduE8A:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kQ4/Z9ShAEnn2l/n03W1W86SIDixv0ArvseGyVj7Rkc=; b=rmdkBRqHRaHurT0BWZelNTJI6d 21Vrxdx/vEAOGXqilZVmO24XCXvPkscApn/PUpS9VY1GNZnFI7wTFhd4WG4RNhnYjATIRzkYCeXYZ Ba7x4zUbsOODkk+oGjbvm8kko; Received: from 75-166-136-83.hlrn.qwest.net ([75.166.136.83]:44574 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qCnO2-002bVE-I1; Fri, 23 Jun 2023 14:28:06 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH 1/4] [gdb/tui] Remove default entries in TUI translation tables References: <20230623111536.1623-1-tdevries@suse.de> X-Attribution: Tom Date: Fri, 23 Jun 2023 14:28:05 -0600 In-Reply-To: <20230623111536.1623-1-tdevries@suse.de> (Tom de Vries's message of "Fri, 23 Jun 2023 13:15:33 +0200") Message-ID: <87fs6h2aay.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.136.83 X-Source-L: No X-Exim-ID: 1qCnO2-002bVE-I1 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-136-83.hlrn.qwest.net (prentzel) [75.166.136.83]:44574 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Tom de Vries writes: > The TUI translation tables contain default entries at the end: > ... > static struct tui_translate tui_border_kind_translate_hline[] = { > { "space", ' ' }, > { "ascii", '-' }, > { "acs", -1 }, > { 0, 0 }, > { "ascii", '-' } > }; > ... > A simpler way of implementing this would be to to declare the first (or last) > entry the default, but in fact these default entries are not used. > Make this explicit by removing the default entries, and asserting in translate > that an entry will always be found. Looks good to me. Tom