From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id ECDEC3858D1E for ; Tue, 20 Jun 2023 14:49:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ECDEC3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id 4563E1004CA63 for ; Tue, 20 Jun 2023 14:49:25 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id Bcfdq9xj1dXwjBcfdqW0ji; Tue, 20 Jun 2023 14:49:25 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=YZd4Wydf c=1 sm=1 tr=0 ts=6491bc75 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=of4jigFt-DYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=BE3rE8ZN7Ds7dDCLFOMA:9 a=zZCYzV9kfG8A:10:nop_mobile_phish_fin_urg a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BnQXuwiSAe6e+poqhFgG7gfbMppXO+31rIQL/glCGls=; b=uMT4C0BfZZetqdDaGIdmzqtJSc vZyLHJOeHRXH9wNFaeH6ArEFJBiD0TIgQ+QSlR4FT5QpsniGBgpKtMRZjJSv1l3y6Ls/uCE3s/sNs IyJe1HSCPepDjoTifV+cjQKWR; Received: from 75-166-136-83.hlrn.qwest.net ([75.166.136.83]:52264 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qBcfd-003et1-28; Tue, 20 Jun 2023 08:49:25 -0600 From: Tom Tromey To: Simon Farre via Gdb-patches Cc: Simon Farre , tom@tromey.com Subject: Re: [PATCH] gdb/DAP Few bug fixes & Evaluate Array Watch vars References: <20230620081549.202591-1-simon.farre.cx@gmail.com> X-Attribution: Tom Date: Tue, 20 Jun 2023 08:49:24 -0600 In-Reply-To: <20230620081549.202591-1-simon.farre.cx@gmail.com> (Simon Farre via Gdb-patches's message of "Tue, 20 Jun 2023 10:15:49 +0200") Message-ID: <87fs6m2npn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.136.83 X-Source-L: No X-Exim-ID: 1qBcfd-003et1-28 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-136-83.hlrn.qwest.net (murgatroyd) [75.166.136.83]:52264 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Farre via Gdb-patches writes: Simon> First of all, name of VariableReferences must always be of string type. Do you mean if it is not None? If so then the EvaluateResult change isn't needed. But if None shouldn't be accepted, then BaseReference.to_object could be changed. Did this cause a problem somewhere? Simon> The result[self.result_name] also f-strings the printer.to_string() Simon> value, because this can potentially be a LazyString (which is a Python Simon> object, not a string) and is not serializable by json.dumps. We've been avoiding f-strings because some LTS distros are stuck on versions of Python without them. I think using str() is fine though. Tom