From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0FC3F3858C50 for ; Fri, 28 Apr 2023 22:49:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0FC3F3858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682722150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Awx8aWkYyBUrjNP/Rvd48XoYb7hNK/LSYsfGikF9y9I=; b=QCE7KHpgH/nT+VUsQVz0aw6TJmSzhAmKQXjAZsXd50S3uIui6ci0Y3omQMaKDRNY7Y0A3B XBcZznQtI9B6D1kn5S63yyJN0sxNTvPAV1sL3oKeZXqEFbzq0nCnYsUatp0Xp27cuMy1wU A1zcx5g65T1MVbQ2IwH3CIlmzGThCHA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-492-x1GBnFwJNHyJ6hcuon-1aw-1; Fri, 28 Apr 2023 18:49:09 -0400 X-MC-Unique: x1GBnFwJNHyJ6hcuon-1aw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f18c2b2110so637185e9.3 for ; Fri, 28 Apr 2023 15:49:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682722148; x=1685314148; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Awx8aWkYyBUrjNP/Rvd48XoYb7hNK/LSYsfGikF9y9I=; b=ghBbbBOHgySxOordbAMWtzc++FQY5AK0xY901g6mlUYf3beVsbT2Zp9m6npDGO2mFW eiibz6sB1BJvbgIlqriV/oauEorHPucUZ5AekWcKzKONfaSO/u7O3a0a7wQYcjM+Q2Zq yxJzQLMmE7060Z7o3LTKbaWyYCyFCs/uoz0XAA3oWfYT3mtuzp8Uka9xNGg2GkdysCUD 5FojDZjpyWkIvSfyY2UsgU2u4QCUqGiHjnpHSG+Ot549gHNbxnuNCmAWBOKSycaIYlZu mQZOFkFRnCFhjCGuD7suW68PLpOy2i30t696rR2gVDPfdmlYlLCj0B3ibh8nBbBQkJPY gUlw== X-Gm-Message-State: AC+VfDyjQS6dchhIkwNSXscYz4LB0LCf0JE5D9e+22y3h0ooFe6vaNUk K1g389WptYIWfhXiaSufsi+Qim2fykmQ19NQ4z5MvXmt7EM6qy3x1Matto8G3MIwuBwxiU9Wewd aafpTtsdzY+Vbt5S1ddFvbB5vPbrj3Q== X-Received: by 2002:a1c:6a14:0:b0:3ed:514d:e07f with SMTP id f20-20020a1c6a14000000b003ed514de07fmr5665245wmc.3.1682722147930; Fri, 28 Apr 2023 15:49:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4wwbd04/lY4OSL5dlcOFKvIVtZ6p1wd03FNDMfEPDCxVSaCMe3i3mvOuSRZDikBvquSBAAgQ== X-Received: by 2002:a1c:6a14:0:b0:3ed:514d:e07f with SMTP id f20-20020a1c6a14000000b003ed514de07fmr5665240wmc.3.1682722147672; Fri, 28 Apr 2023 15:49:07 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id iz14-20020a05600c554e00b003f175954e71sm28876543wmb.32.2023.04.28.15.49.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Apr 2023 15:49:07 -0700 (PDT) From: Andrew Burgess To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/5] gdb/doc: improve Python Disassembler API documentation In-Reply-To: <83y1n7ubex.fsf@gnu.org> References: <3cdddabce2d5acfbdb9a8c5bdcb1a205a2bd01e5.1680596378.git.aburgess@redhat.com> <83y1n7ubex.fsf@gnu.org> Date: Fri, 28 Apr 2023 23:49:06 +0100 Message-ID: <87fs8jaahp.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Eli Zaretskii writes: >> Cc: Andrew Burgess >> Date: Tue, 4 Apr 2023 09:21:03 +0100 >> From: Andrew Burgess via Gdb-patches >> >> --- a/gdb/doc/python.texi >> +++ b/gdb/doc/python.texi >> @@ -6909,7 +6909,7 @@ >> @code{RuntimeError} exception if it is invalid. >> @end defun >> >> -@defun DisassembleInfo.__init__ (info) >> +@defun DisassembleInfo.__init__ (@var{info}) > > You consistently rewrite the Texinfo source to use @var inside the > argument lists of a @defun. I already asked why, as I don't think > this is required. I don't think you replied. So once again: why are > you doing this? what problems happen if you don't? This is an unfortunate consequence of me posting many patches in similar areas of GDB. All of these landed on the list prior to you enlightening me that @var is not needed -- it's not me ignoring you. I should have been more proactive in reviewing my in-flight patches for this error to avoid wasting your time. This change will, of course, be removed from this patch. Thanks for your patience, Andrew > > Otherwise, this is fine. Thanks. > > Reviewed-By: Eli Zaretskii