From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id 882753858C83 for ; Fri, 21 Apr 2023 14:37:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 882753858C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id D631610052AE8 for ; Fri, 21 Apr 2023 14:37:13 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id prsvpP4mUNkLmprsvp5BB3; Fri, 21 Apr 2023 14:37:13 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=UYmU9IeN c=1 sm=1 tr=0 ts=64429f99 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=dKHAf1wccvYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=lzDhS8hmAAAA:8 a=eExMjbdWsrTahIHVESYA:9 a=rigQk1bY_8VmChEzA3fK:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hFR37mFY8S3MqvjgnnwQudK7b6k2bI6DwzczdpuJuBg=; b=Tqv0T4ZaMHyd5ne9l78y9ryz6m u9LxrT4n4AQ5SDCDFP+S9OBRfK5zV11ILyvYg01j7ya0/SSbe7Mxs9i+H0QXjwOf/59LJ9ECbUBNJ u3aCDvhNMKI2BbajUAnrRfQlB; Received: from 71-211-191-82.hlrn.qwest.net ([71.211.191.82]:33650 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pprsu-002CKK-Gj; Fri, 21 Apr 2023 08:37:12 -0600 From: Tom Tromey To: Sandra Loosemore Cc: Subject: Re: [PATCH 2/5] gdb/testsuite: Fix style.exp failures on targets without libopcodes styling References: <20230419193046.548783-1-sandra@codesourcery.com> <20230419193046.548783-3-sandra@codesourcery.com> X-Attribution: Tom Date: Fri, 21 Apr 2023 08:37:10 -0600 In-Reply-To: <20230419193046.548783-3-sandra@codesourcery.com> (Sandra Loosemore's message of "Wed, 19 Apr 2023 13:30:43 -0600") Message-ID: <87fs8t1euh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.191.82 X-Source-L: No X-Exim-ID: 1pprsu-002CKK-Gj X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-191-82.hlrn.qwest.net (murgatroyd) [71.211.191.82]:33650 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Sandra" == Sandra Loosemore writes: Sandra> Do not expect disassembler output to be styled by libopcodes if GDB Sandra> reports the target does not support that. Sandra> +# Check whether libopcodes styling is supported for this target. Sandra> +set have_libopcodes_styling 1 Sandra> +proc test_for_libopcodes_styling {} { Sandra> + global binfile Sandra> + global have_libopcodes_styling Sandra> + clean_restart ${binfile} Sandra> + Sandra> + gdb_test_multiple "maint set libopcodes-styling enabled on" "" { Sandra> + -re "^maint set libopcodes-styling enabled on\r\n" Sandra> + { The Tcl style usually puts the "{" at the end of the previous line. Here it may not matter, so it's just stylistic. However due to Tcl's unusual lexing, it does matter in some spots, so IMO it's best to be consistent. Tcl represents the ultimate achievement of a certain style -- they managed to enforce "{" placement in the language. If only GNU were so enterprising. Tom