From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 48A1B3858C50 for ; Mon, 17 Apr 2023 15:26:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 48A1B3858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id AA0DB10041A4E for ; Mon, 17 Apr 2023 15:26:34 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id oQkUpqjztAFlaoQkUpf6rC; Mon, 17 Apr 2023 15:26:34 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=BoVYfab5 c=1 sm=1 tr=0 ts=643d652a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=dKHAf1wccvYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=cnmB7EnFDvPNwlxzYREA:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/l7kF/m3x0oYCoiosiQrtqlorvwQhBDytqZ6/Vi3hbA=; b=b3s2SAQ3gxAOetkTkthOb1u/Hg fEUJu4Iu2aqOSvHYK4YvPLO+2VHmnVg71hijqEDxK36meauiz0ISM6ITzfWdFv2R3DHHuL6TSl0jt fDjMGMfO3huAXUDXofY7kzi0r; Received: from 71-211-191-82.hlrn.qwest.net ([71.211.191.82]:36516 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1poQkU-000hKg-Bt; Mon, 17 Apr 2023 09:26:34 -0600 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess Subject: Re: [PATCHv2] gdb/python: add mechanism to manage Python initialization functions References: <87y1timiew.fsf@tromey.com> <20221021131724.1446620-1-aburgess@redhat.com> X-Attribution: Tom Date: Mon, 17 Apr 2023 09:26:33 -0600 In-Reply-To: <20221021131724.1446620-1-aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Fri, 21 Oct 2022 14:17:24 +0100") Message-ID: <87fs8y4jiu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.191.82 X-Source-L: No X-Exim-ID: 1poQkU-000hKg-Bt X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-191-82.hlrn.qwest.net (murgatroyd) [71.211.191.82]:36516 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: I saw this today and realized I'd forgotten to reply to it. It wasn't intentional. Andrew> I'm not a huge fan of our existing make-init-c system. I think, now Andrew> we've moved to C++ there are "in-lanaguage" ways we could achieve the Andrew> same result without having to generate code. Though I'm have no plans Andrew> to try and change the existing _initialize_* mechanism. Seems fair. I was worried about the static initialization problems we've hit before, but I see you have fixed those. And actually your patch makes me want to do the same for unit tests, so we can move the gdbsupport unit tests into gdbsupport/ where (IMO) they belong. Andrew> If you don't like this any more than my first attempt then I'll finish Andrew> off the make-init-c patch, but I thought I'd post this first and see Andrew> what you thought. This looks good to me. Reviewed-By: Tom Tromey Andrew> -int Andrew> +static int CPYCHECKER_NEGATIVE_RESULT_SETS_EXCEPTION Andrew> gdbpy_initialize_arch (void) Not a problem you need to address, but I'm not sure we can even run the Python checker any more, now that gdb is using C++ (and things like gdbpy_ref<>). thanks, Tom