From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH 0/2] Change find_thread_ptid functions to be methods
Date: Tue, 04 Apr 2023 12:44:45 -0600 [thread overview]
Message-ID: <87fs9fa3mq.fsf@tromey.com> (raw)
In-Reply-To: <20230327165355.89228-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Mon, 27 Mar 2023 12:53:53 -0400")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> I thought it would make sense for the that the find_thread_ptid
Simon> functions to be methods of inferior and process_stratum_target.
Simon> Especially the inferior one, as it searches in data that is private
Simon> (conceptually) to the inferior class. I changed the
Simon> process_stratum_target one too, while at it.
These seem fine to me. Thanks.
Reviewed-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2023-04-04 18:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 16:53 Simon Marchi
2023-03-27 16:53 ` [PATCH 1/2] gdb: make find_thread_ptid an inferior method Simon Marchi
2023-03-27 16:53 ` [PATCH 2/2] gdb: make find_thread_ptid a process_stratum_target method Simon Marchi
2023-04-04 18:44 ` Tom Tromey [this message]
2023-04-05 1:06 ` [PATCH 0/2] Change find_thread_ptid functions to be methods Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs9fa3mq.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).