From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id 340263858D37 for ; Fri, 3 Mar 2023 19:16:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 340263858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id 474F81004A840 for ; Fri, 3 Mar 2023 19:16:05 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id YAsvpH2QoNX2aYAsvpzIv5; Fri, 03 Mar 2023 19:16:05 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=64024775 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=N_YTqoMHY_WFuVnWHAcA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8PyfyFx7jRGG2gpjYAslOC8keW8Rtx95FcNWfHN0CWI=; b=YvvCUsMH/jRzDeuUqPJtuAlVKV eLfvvaEQOgtf/5TDGoWgGsZPmJ2sYWECoalt/Q+bjnii8YJJ6OqOmNWUP9sYLtZawj926isKr3gD+ zDlviG96EdsvG//Knpsmi2o3H; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:35630 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pYAsu-004OVR-Tl; Fri, 03 Mar 2023 12:16:04 -0700 From: Tom Tromey To: John Baldwin Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/5] Various test suite fixes (mostly thread related) References: <20230217203818.11287-1-jhb@FreeBSD.org> X-Attribution: Tom Date: Fri, 03 Mar 2023 12:16:02 -0700 In-Reply-To: <20230217203818.11287-1-jhb@FreeBSD.org> (John Baldwin's message of "Fri, 17 Feb 2023 12:38:13 -0800") Message-ID: <87fsal8x3h.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pYAsu-004OVR-Tl X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:35630 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: John> I've been working on a series of patches for the FreeBSD native target John> to fix various issues with multiprocessing over the past month or two. John> During that time I have fixed a few issues in various tests I've John> observed so far. This series is just some of the test fixes. Thank you for doing this. John> Patches 3 and 4 fix synchronization issues where tests were assuming John> that if the main thread calls pthread_create and then exits, the new John> thread will start executing bofore the main thread exits. I like the barrier technique. John> The last patch is a bit more of a RFC and probably not really the way John> we want to fix the issue. Some tests assume that the format of 'info John> threads' is to have thread identifiers start with "Thread". However, John> some targets use a different format. For example FreeBSD's native John> target refers to threads as "LWP ". There are some existing John> tests that use a looser regex here already rather than requiring the John> word "Thread". I wonder if we want to define a helper macro or John> variable or like to contain the regex to use for matching on a valid John> thread identifier instead? I think a helper variable would be fine. We already have a few of these in gdb.exp, like 'octal' or 'bkptno_numopt_re'. I think patches 1-4 are OK as-is. thanks, Tom