From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id 1F5A33858D1E for ; Tue, 14 Feb 2023 20:46:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F5A33858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id 98ADE1004A24E for ; Tue, 14 Feb 2023 20:46:21 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id S2Bxpj389jkdRS2Bxpci20; Tue, 14 Feb 2023 20:46:21 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=LPqj/La9 c=1 sm=1 tr=0 ts=63ebf31d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=gLXedNc-FFpINB1_z-gA:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=RdEU8hmr3IzJSHdDFWxmfZW5t5IEOcAfqbMMQeTsalo=; b=CCz5L1oe/a8anufufUPRwj2OZ1 xZGAKPkkngYEm9lv3iZqSfiKbgp6kWCGg5fcrHpNooOq/jB7eZVs5uzZx2MHz+606Spc1RnVCNZIF U8OFBEpX+sSNJfzCDbZDWqu0Y; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:36880 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pS2Bx-003Hnb-Bh; Tue, 14 Feb 2023 13:46:21 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH v2 3/3] gdb: store internalvars in an std::map References: <20230214192327.318301-1-simon.marchi@efficios.com> <20230214192327.318301-3-simon.marchi@efficios.com> X-Attribution: Tom Date: Tue, 14 Feb 2023 13:46:17 -0700 In-Reply-To: <20230214192327.318301-3-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Tue, 14 Feb 2023 14:23:27 -0500") Message-ID: <87fsb8rn52.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pS2Bx-003Hnb-Bh X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:36880 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> In a test downstream in ROCgdb, we had a test case failing when Simon> GDB_REVERSE_INIT_FUNCTIONS was set. The test was assuming a particular Simon> order in the output of "show convenience". And the order changes when Simon> running with GDB_REVERSE_INIT_FUNCTIONS. Simon> I think that a nice way to fix it is to make the output of "show Simon> convenience" sorted, and therefore stable. Ideally, I think that the Simon> the user-visible behavior of GDB should not change when using Simon> GDB_REVERSE_INIT_FUNCTIONS. Plus, it makes the output of "show Simon> convenience" look nice, not that it's really important. Simon> Implement this by storing the internal vars in an std::map, which is a Simon> sorted container. Makes sense to me. Approved-By: Tom Tromey Tom