From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 552A938AA24B for ; Fri, 10 Feb 2023 17:46:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 552A938AA24B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id B02371004369B for ; Fri, 10 Feb 2023 17:46:10 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id QXTOpV4SWKCpNQXTOpAMfh; Fri, 10 Feb 2023 17:46:10 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=W8X96Tak c=1 sm=1 tr=0 ts=63e682e2 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=dzWzf_mpAAAA:8 a=RS8xARU7pegkgzO0GNoA:9 a=b4DR9a7p2ZdsqdHBznES:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zDlVci7oPamBVJLhT8LWBZtQzrrNZRmemLh2g3LCSLA=; b=PLMaf0aOqy7Ufn6ku46hCkFbE7 3tDjA9rOS5XZzp25P6NTCo2isEKy5KqL/jac3VS9vDRzKaCOrrBhieHOYvgO33IEUAeUmmSIVIKHR mBsozibv7m4lhUlqE+4SIESZD; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:46502 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pQXTO-001InR-9q; Fri, 10 Feb 2023 10:46:10 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 33/47] Turn remaining value_contents functions into methods References: <20230209-submit-value-fixups-2023-v1-0-55dc2794dbb9@tromey.com> <20230209-submit-value-fixups-2023-v1-33-55dc2794dbb9@tromey.com> X-Attribution: Tom Date: Fri, 10 Feb 2023 10:46:07 -0700 In-Reply-To: (Simon Marchi's message of "Thu, 9 Feb 2023 21:24:04 -0500") Message-ID: <87fsbdifc0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pQXTO-001InR-9q X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (prentzel) [75.166.130.93]:46502 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: >> diff --git a/gdb/value.h b/gdb/value.h >> index 2d1c489e245..7b034bba1e2 100644 >> --- a/gdb/value.h >> +++ b/gdb/value.h >> @@ -282,7 +282,7 @@ struct value >> >> When we store the entire object, `enclosing_type' is the run-time >> type -- the complete object -- and `embedded_offset' is the offset >> - of `type' within that larger type, in bytes. The value_contents() >> + of `type' within that larger type, in bytes. The ->contents() >> macro takes `embedded_offset' into account, so most GDB code Simon> I randomly spotted this oddity, "->contents()". I think there are other Simon> instances too. Also, it still talks about a macro... that could Simon> probably be updated while at it. I fixed this, then looked at the final combined patch for other instances of " ->" and didn't see any. I also fixed the macro thing, which must be from very long ago. Tom