From: Tom Tromey <tom@tromey.com>
To: Aaron Merey via Gdb-patches <gdb-patches@sourceware.org>
Cc: keiths@redhat.com, Aaron Merey <amerey@redhat.com>
Subject: Re: [PATCH] gdb/source: Fix open_source_file error handling
Date: Wed, 08 Feb 2023 10:53:57 -0700 [thread overview]
Message-ID: <87fsbg11sa.fsf@tromey.com> (raw)
In-Reply-To: <20230202013853.119354-1-amerey@redhat.com> (Aaron Merey via Gdb-patches's message of "Wed, 1 Feb 2023 20:38:53 -0500")
Ok, I re-read the patch and see you did use ATTRIBUTE_NORETURN. Sorry
about that. And adding an optional argument means changing gdbserver as
well... IMO this is fine but up to you.
Though it seems to me that:
Aaron> + bfd_set_error (bfd_error_no_error);
Aaron> + errno = 0;
... these two lines are probably leftovers from ancient times, when the
gdb exception mechanism was much less robust. They should not be in new
code, and TBH probably the best route forward is to remove them from
utils.c, and in fact merge the definition of perror_with_name into
gdbsupport, since AFAICT it's really identical between gdb and
gdbserver.
Tom
next prev parent reply other threads:[~2023-02-08 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 3:37 Aaron Merey
2023-02-01 19:45 ` Keith Seitz
2023-02-02 1:38 ` Aaron Merey
2023-02-08 17:53 ` Tom Tromey [this message]
2023-02-02 10:29 ` Bruno Larsen
2023-02-08 17:44 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsbg11sa.fsf@tromey.com \
--to=tom@tromey.com \
--cc=amerey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).