From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id B21383858D39 for ; Wed, 8 Feb 2023 17:53:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B21383858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 2CAB61004855D for ; Wed, 8 Feb 2023 17:53:59 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id Podrp08fvNX2aPodrplHck; Wed, 08 Feb 2023 17:53:59 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=63e3e1b7 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=kwhlhaF1VBSyqyGklg8A:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=63aqziHXBNUqGgby+VKwCnQZ15NT60ZqlpdCvWDDY4I=; b=pgU6O4g7QK4zayliLjFjqqLyST 4+6zC83Yu2SCqa/xoMkpFd3+CsQRp3YxjY9t2ndL2yfHqEpARYlhOKBiAi979nNhNXBTbgUDqmo0x LLfcPr33/2jx5PmoKFhCjuKWZ; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:55644 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pPodq-003Qbk-OF; Wed, 08 Feb 2023 10:53:58 -0700 From: Tom Tromey To: Aaron Merey via Gdb-patches Cc: keiths@redhat.com, Aaron Merey Subject: Re: [PATCH] gdb/source: Fix open_source_file error handling References: <20230202013853.119354-1-amerey@redhat.com> X-Attribution: Tom Date: Wed, 08 Feb 2023 10:53:57 -0700 In-Reply-To: <20230202013853.119354-1-amerey@redhat.com> (Aaron Merey via Gdb-patches's message of "Wed, 1 Feb 2023 20:38:53 -0500") Message-ID: <87fsbg11sa.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pPodq-003Qbk-OF X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:55644 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ok, I re-read the patch and see you did use ATTRIBUTE_NORETURN. Sorry about that. And adding an optional argument means changing gdbserver as well... IMO this is fine but up to you. Though it seems to me that: Aaron> + bfd_set_error (bfd_error_no_error); Aaron> + errno = 0; ... these two lines are probably leftovers from ancient times, when the gdb exception mechanism was much less robust. They should not be in new code, and TBH probably the best route forward is to remove them from utils.c, and in fact merge the definition of perror_with_name into gdbsupport, since AFAICT it's really identical between gdb and gdbserver. Tom