From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qproxy3-pub.mail.unifiedlayer.com (qproxy3-pub.mail.unifiedlayer.com [67.222.38.20]) by sourceware.org (Postfix) with ESMTPS id B05183858C50 for ; Fri, 20 Jan 2023 20:00:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B05183858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by qproxy3.mail.unifiedlayer.com (Postfix) with ESMTP id C1C0F802E248 for ; Fri, 20 Jan 2023 20:00:18 +0000 (UTC) Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id ACEF1100421CE for ; Fri, 20 Jan 2023 19:59:18 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id IxXiphJZ5FqSRIxXip1JYy; Fri, 20 Jan 2023 19:59:18 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=c6Ru/Txl c=1 sm=1 tr=0 ts=63caf296 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10:nop_charset_1 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=cAJmHX3586rBOCyE6WsA:9 a=QEXdDO2ut3YA:10:nop_charset_2 a=YN2k8xjJL5IA:10:demote_hacked_domain_1 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=z4yGeb6H/jwBZoDjmzHya7Vbv/NyjMR8uFoHhEeZnO4=; b=qB0C5WKQ/ICGRFW664O2gOpj0E x434QrZeT6JggTKFgl7XcfcfhWIU2nwWa938q5mUUVVEA9LcuTczGsGoTiu3TiLahcM3hP/h8v7ji GrrgNmqoerYv+bdB6FFkL7rMf; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:43500 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pIxXi-003xYw-5I; Fri, 20 Jan 2023 12:59:18 -0700 From: Tom Tromey To: =?utf-8?Q?Torbj=C3=B6rn?= SVENSSON via Gdb-patches Cc: =?utf-8?Q?Torbj=C3=B6rn?= SVENSSON , , , Yvan Roux Subject: Re: [PATCH v3 1/2] gdb: dwarf2 generic implementation for caching function data References: <20230119102948.3069226-1-torbjorn.svensson@foss.st.com> X-Attribution: Tom Date: Fri, 20 Jan 2023 12:59:15 -0700 In-Reply-To: <20230119102948.3069226-1-torbjorn.svensson@foss.st.com> (=?utf-8?Q?=22Torbj=C3=B6rn?= SVENSSON via Gdb-patches"'s message of "Thu, 19 Jan 2023 11:29:48 +0100") Message-ID: <87fsc5x9ik.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pIxXi-003xYw-5I X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:43500 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Torbj=C3=B6rn SVENSSON via Gdb-patches w= rites: > v2 -> v3: > Addressed comments from Tom in > https://sourceware.org/pipermail/gdb-patches/2023-January/195882.html Sorry, I'm afraid you missed a few. > +struct dwarf2_frame_fn_data > +{ > + /* The cookie to identify the custom function data by. */ > + fn_prev_register cookie; The previous review mentioned changing the type of this, but honestly I don't really care about that one, this is as good as anything now that it's documented. > +/* See frame.h. */ > + > +void *dwarf2_frame_get_fn_data (frame_info_ptr this_frame, void **this_c= ache, > + fn_prev_register cookie) gdb style puts the function name at the start of the line. There are many examples in the source. > +void *dwarf2_frame_allocate_fn_data (frame_info_ptr this_frame, > + void **this_cache, > + fn_prev_register cookie, > + unsigned long size) Here too. > +{ > + struct dwarf2_frame_fn_data *fn_data =3D nullptr; > + struct dwarf2_frame_cache *cache > + =3D dwarf2_frame_cache (this_frame, this_cache); > + > + /* First try to find an existing object. */ > + void *data =3D dwarf2_frame_get_fn_data (this_frame, this_cache, cooki= e); > + if (data) > + return data; It seems to me that there is no need to do this check. IMO it's fine to just assert that it isn't found. thanks, Tom