From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 7A85C3858D33 for ; Tue, 10 Jan 2023 23:35:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7A85C3858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id E222E10046FC2 for ; Tue, 10 Jan 2023 23:35:06 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id FO94plZOTuK4dFO94pclBW; Tue, 10 Jan 2023 23:35:06 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=XpE/hXJ9 c=1 sm=1 tr=0 ts=63bdf62a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=P6V3FpRaDOTHu-bfo-sA:9 a=QYH75iMubAgA:10:nop_sms_unsolicited a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/8xquhDT3fgZRNeQ/3s4VP8AbW3YS0wkHobMHH3CBA8=; b=sxZcXbBRis/xGYDo88mGyqIkfD uMrpX6moM9wm24LjMoRpRgvD8Le4QqdHsVZ7WGKj310rJr09OmJeeoClvbirHooe1vWaFngEnJj69 o08ZxvhlS6d8YraD3Xd6nPiID; Received: from [161.98.8.3] (port=41476 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pFO94-000F96-6m; Tue, 10 Jan 2023 16:35:06 -0700 From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Convert say_where to method on code_breakpoint References: <20230110151821.2302229-1-tromey@adacore.com> X-Attribution: Tom Date: Tue, 10 Jan 2023 16:35:01 -0700 In-Reply-To: <20230110151821.2302229-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Tue, 10 Jan 2023 08:18:21 -0700") Message-ID: <87fsci55ga.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 161.98.8.3 X-Source-L: No X-Exim-ID: 1pFO94-000F96-6m X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (prentzel) [161.98.8.3]:41476 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> 'say_where' is only useful (and only called for) code breakpoints, so Tom> convert it to be a protected method on code_breakpoint. Tom> - struct bp_location *loc = b->loc; Tom> + struct bp_location *loc = loc; Tom> int n = 0; Tom> for (; loc; loc = loc->next) Tom> ++n; This hunk is wrong but I didn't notice until now. Sorry about this. I'll fix it momentarily. Tom