From: Tom Tromey <tom@tromey.com>
To: Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org>
Cc: Bruno Larsen <blarsen@redhat.com>
Subject: Re: [PATCH] gdb/testsuite: Fix FAILs in gdb.linespec/cpcompletion.exp when using clang
Date: Thu, 05 Jan 2023 13:06:38 -0700 [thread overview]
Message-ID: <87fscod9v5.fsf@tromey.com> (raw)
In-Reply-To: <20230105075705.2271636-1-blarsen@redhat.com> (Bruno Larsen via Gdb-patches's message of "Thu, 5 Jan 2023 08:57:05 +0100")
>>>>> Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:
> When using clang 16.0.0 to test gdb.linespec/cpcompletion.exp, I get 99
> unexpected failures. They all fail to produce a complete list of
> completion options for a function, either overload2_function,
> overload3_function or anon_ns_function. This happens because clang is
> optimizing them away, since they are never used.
> Fix this by adding __attribute__((used)) to all declarations to the
> aforementioned functions.
Thanks for the patch. I guess we use this attribute in the tests
already, so I think this is ok.
Tom
next prev parent reply other threads:[~2023-01-05 20:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 7:57 Bruno Larsen
2023-01-05 20:06 ` Tom Tromey [this message]
2023-01-06 9:51 ` Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fscod9v5.fsf@tromey.com \
--to=tom@tromey.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).