From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id D4B04385516A for ; Mon, 28 Nov 2022 21:00:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D4B04385516A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 978E210274086 for ; Mon, 28 Nov 2022 20:34:17 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id zkpVoLmyshFiDzkpVoSrCu; Mon, 28 Nov 2022 20:34:17 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=D6qCltdj c=1 sm=1 tr=0 ts=63851b49 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=9xFQ1JgjjksA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=KwUsxX7bhct5WXJEwiwA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=lR/yA3xr+83TwF9sZXh5fJUbDR6Fo8gvnsvQMJe9LSY=; b=JKmXpQ1BTvLdoXukFaDXxh8dMH gjdVSxPLKjOVRlaxpp/XtjCV3BzozIYgjAj9mg1pj0SkjSjS26uS9jT+1c/euERcj8GNt9h1Fitnv UnM2vt0BPZknY6RUMt0swjNpJ; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56902 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ozkpV-002cNx-3b; Mon, 28 Nov 2022 13:34:17 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Tom Tromey , Simon Marchi Subject: Re: [PATCH 3/3] Don't let gdb_stdlog use pager References: <20221117182904.1291713-1-tromey@adacore.com> <20221117182904.1291713-4-tromey@adacore.com> <9411d46c-14b5-1e12-08d7-2732b1d52750@simark.ca> X-Attribution: Tom Date: Mon, 28 Nov 2022 13:34:15 -0700 In-Reply-To: <9411d46c-14b5-1e12-08d7-2732b1d52750@simark.ca> (Simon Marchi via Gdb-patches's message of "Mon, 28 Nov 2022 14:23:59 -0500") Message-ID: <87fse2om2g.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1ozkpV-002cNx-3b X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56902 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3028.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: >> diff --git a/gdb/cli/cli-interp.h b/gdb/cli/cli-interp.h >> index fa007d78621..978e7f291e4 100644 >> --- a/gdb/cli/cli-interp.h >> +++ b/gdb/cli/cli-interp.h >> @@ -42,6 +42,7 @@ class cli_interp_base : public interp >> ui_file *targ; >> ui_file *targerr; >> ui_file_up tee_to_delete; >> + ui_file_up stderr_to_delete; >> ui_file_up file_to_delete; >> ui_file_up log_to_delete; Simon> I think it would help me understand if the naming of these fields was a Simon> bit better. I think the to_delete suffixes are no longer relevant Simon> since using ui_file_up, the types tell us about the ownership. And I Simon> think that "tee_to_delete" could be named "stdout_tee", and Simon> "stderr_to_delete" could be named "stderr_tee". Simon> Not terribly important, perhaps as a follow up. I'll send a follow-up for this as well. Tom