From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 6AD843857C51 for ; Fri, 18 Nov 2022 19:05:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6AD843857C51 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id BDF7210126508 for ; Fri, 18 Nov 2022 18:04:30 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id w5j4o6t6sBHaww5j4o6pxz; Fri, 18 Nov 2022 18:04:30 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=S4gcfKgP c=1 sm=1 tr=0 ts=6377c92e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=9xFQ1JgjjksA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=W5kD2FXJOIVB3xLck_AA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=tK1rB4+zymPR1MxND3uIKjS5/2s9zOwv9umoqhfV+Mo=; b=SquorXMVCB5ebIo+ebj0PYUGu3 aSUduWcKXqlikv+hRE8CNa9JcJ2ffVXDq8b6I2UxkIO5kHUpuv37OUGZKvxxQaE0/SnrcfcmHpRtX hp6YM0wzfEINPm6R2mK10z05e; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56876 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ow5j4-000FhT-99; Fri, 18 Nov 2022 11:04:30 -0700 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess Subject: Re: [PATCHv3 7/7] gdb: some process_stratum_target should not be shared References: <577f2c47793acb501c2611c0e6c7ea379f774830.1668789658.git.aburgess@redhat.com> X-Attribution: Tom Date: Fri, 18 Nov 2022 11:04:28 -0700 In-Reply-To: <577f2c47793acb501c2611c0e6c7ea379f774830.1668789658.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Fri, 18 Nov 2022 16:42:58 +0000") Message-ID: <87fsegqgur.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1ow5j4-000FhT-99 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56876 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> For things like the Linux and FreeBSD native targets, as well as the Andrew> remote target, this is absolutely true (or was made true). But some Andrew> targets were never updated to be shareable, for example, the Andrew> core_target, which is used when reading core-files, stores some of its Andrew> state in the program_space, but also, the core-file and the executable Andrew> being debugged are closely related. Andrew> As each add-inferior call creates an inferior with a new Andrew> program_space, and doesn't automatically copy the executable, or the Andrew> current core-file, I don't think it really makes sense to "share" Andrew> core_target objects between inferiors. Yeah, probably the core target just doesn't even make sense to share. I guess if we did want to share it, we could move the state into the core target. Maybe this is worthwhile to do anyway? I see a bunch of uses of core_bfd (which is a #define reaching into the program space), but some, e.g. in linux_read_core_file_mappings, seem like they could be replaced with a parameter. Andrew> I think this behaviour might be confusing, so I'd like to have GDB not Andrew> initially share the core connection. Instead, when the user tries to Andrew> add the new inferior a warning is given, and the new inferior is Andrew> created without a connection, like this: This makes sense to me. Andrew> + /* The core_target only works for the inferior in which it was initially Andrew> + opened, and can't be copied to some other inferior's target_stack. */ Andrew> + bool is_shareable () override Andrew> + { return false; } However, why only mark the core target this way? I think there are a lot of other targets that can't be shared... remote-sim, all the trace targets, even I think windows-nat, since it isn't multi-inferior-capable yet. So maybe the default implementation should be 'return false' and then specific known-good targets should override it? Tom