From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 07B8D3856161 for ; Fri, 28 Oct 2022 11:38:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 07B8D3856161 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666957087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P3DzNmNjJ/VqenK6exvm+QiPcguFUX6Z2HEAG99M6kQ=; b=IFKGpwr3pbtypJSq1nziEB9tzIvhawHeFhAyLV5ioGzDTg4D9Gww1RQWj3u/cSkYaqDXT7 nlgkqP6l9sx1ZXmPLb92fD5UAN4Zb1Bxi7LlK4QTPPSP8OWkUkr5PJ/ymbpmthaknrNReZ 8tZmQrsCnmuIrVhPSUhtyMgqip4ng4U= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-385-MtbSh3HIMD-Uu8ZjzRDBrg-1; Fri, 28 Oct 2022 07:38:06 -0400 X-MC-Unique: MtbSh3HIMD-Uu8ZjzRDBrg-1 Received: by mail-wr1-f72.google.com with SMTP id d23-20020adfa417000000b002364a31b7c9so1094931wra.15 for ; Fri, 28 Oct 2022 04:38:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P3DzNmNjJ/VqenK6exvm+QiPcguFUX6Z2HEAG99M6kQ=; b=eKirCnNzAfL6QfDfUsDLoO5vw33cz+U2LW26fyVOAWfJcNysbsIBQCrbPPewtwpKAk VlWS6b0SD1RS9MIMhMPvVu3yuNJBsQUdK0Da1KnNwKnh+R3K/eaObcX0CmFAR6LgKWFn EAB+S5Kp202ISCELqWJ4rmBmAlV+ANrDBvkcjgaWP427pkm88+j2F1gcCx7QURyr+e1h HjBDFVzKJsu9GKfbyA/vpqroLVPxdr7Y0dAIV0urHXizyh9qY0bWsAyLoT4tCGCoRsNC 7lRNIWPyNlgG4Uax1hPNjgipmCFxnWFKxx4mjhJCUBOCsfd53D8bNk/aZ/WhnjIC6hOF VrZQ== X-Gm-Message-State: ACrzQf0Y7Xy7NPOdnr94sBX3WOHcPirSu+C0GaNL62PQY2ZPjL9Rsu/j 7LIsDIfq7ksFCNhktDliAlUark+xCfA5qWQOPMTZDRvqp7za1Py3yx1Jog4TjUbFGnWPY2iWkWP qsSkrA77y4FHE7HBRRpbC9Q== X-Received: by 2002:a05:6000:1888:b0:236:8b32:cb47 with SMTP id a8-20020a056000188800b002368b32cb47mr8149753wri.601.1666957085064; Fri, 28 Oct 2022 04:38:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5wtpC+TbQEQpyAw/UtV9tRIMwg1/al96qO4pTx1CKnQ5F33RPYxXwTYFzW7jvEhBqGrcLMxw== X-Received: by 2002:a05:6000:1888:b0:236:8b32:cb47 with SMTP id a8-20020a056000188800b002368b32cb47mr8149743wri.601.1666957084870; Fri, 28 Oct 2022 04:38:04 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id n15-20020a056000170f00b0022cd0c8c696sm3609411wrc.103.2022.10.28.04.38.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 04:38:04 -0700 (PDT) From: Andrew Burgess To: Bruno Larsen , gdb-patches@sourceware.org Subject: Re: [PATCH 06/11] gdb/testsuite: add XFAIL to gdb.cp/ptype-flags.exp when using clang In-Reply-To: References: <20221004170747.154307-1-blarsen@redhat.com> <20221004170747.154307-8-blarsen@redhat.com> <8735ba7k4b.fsf@redhat.com> Date: Fri, 28 Oct 2022 12:38:03 +0100 Message-ID: <87fsf8ch5w.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Bruno Larsen writes: > On 26/10/2022 16:08, Andrew Burgess wrote: >> Bruno Larsen via Gdb-patches writes: >> >>> When running gdb.cp/ptype-flags.exp using clang, we get an unexpected >>> failure when printing the type of a class with an internal typedef. This >>> happens because clang doesn't add accessibility information for typedefs >>> inside classes (see https://github.com/llvm/llvm-project/issues/57608 >>> for more info). To help with clang testing, an XFAIL was added to this >>> test. >>> --- >>> gdb/testsuite/gdb.cp/ptype-flags.exp | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/gdb/testsuite/gdb.cp/ptype-flags.exp b/gdb/testsuite/gdb.cp/ptype-flags.exp >>> index f88c83e03ce..e8d3f285803 100644 >>> --- a/gdb/testsuite/gdb.cp/ptype-flags.exp >>> +++ b/gdb/testsuite/gdb.cp/ptype-flags.exp >>> @@ -30,11 +30,18 @@ if ![runto_main] then { >>> return >>> } >>> >>> +if {[test_compiler_info {clang-*-*}]} { >>> + set using_clang true >>> +} else { >>> + set using_clang false >>> +} >> Missing the language for the test_compiler_info call. Looks good with >> that fixed. > Great! Can I add an Approved-by tag to the patch? Sure, with that fix made. Thanks, Andrew > > Cheers, > Bruno > >> Thanks, >> Andrew >> >>> + >>> gdb_test_no_output "set language c++" "" >>> gdb_test_no_output "set width 0" "" >>> >>> proc do_check_holder {name {flags ""} {show_typedefs 1} {show_methods 1} >>> {raw 0}} { >>> + global using_clang >>> >>> set contents { >>> { base "public Base" } >>> @@ -49,6 +56,11 @@ proc do_check_holder {name {flags ""} {show_typedefs 1} {show_methods 1} >>> } >>> >>> if {$show_typedefs} { >>> + # Clang does not add accessibility information for typedefs: >>> + # https://github.com/llvm/llvm-project/issues/57608 >>> + if {$using_clang} { >>> + setup_xfail "clang 57608" *-*-* >>> + } >>> lappend contents { typedef public "typedef Simple > Z;" } >>> } >>> >>> -- >>> 2.37.3