From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 5D4B63856DC0 for ; Fri, 21 Oct 2022 18:05:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5D4B63856DC0 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 678AF100C69FC for ; Fri, 21 Oct 2022 18:05:03 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id lwOEo2zFUoMaxlwOFo7Umv; Fri, 21 Oct 2022 18:05:03 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=X4CXlEfe c=1 sm=1 tr=0 ts=6352df4f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=Qawa6l4ZSaYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=o0aJNIb_EADkNXfKqi0A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Ll/dOudeaNeRcBlGWzWrPkbqjtendtEniKSBAzUiJ6s=; b=J7Gf5LqUlV8s8qieh3lsXLjFX4 F54biwLJXomXo1wdL0tcg4w+Ea7WddTIBsi+p0HE+RF194MUcW8m5v8MSG2FGr4lpDpwEzWr0qUwU ed5ctNdhn5ESjcI3WrhC7q4yL; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56750 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1olwOE-0005Z6-2i; Fri, 21 Oct 2022 12:05:02 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH 2/2] gdb: make inherit_abstract_dies use vector iterators References: <20221021132104.1772565-1-simon.marchi@polymtl.ca> <20221021132104.1772565-2-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Fri, 21 Oct 2022 12:04:59 -0600 In-Reply-To: <20221021132104.1772565-2-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Fri, 21 Oct 2022 09:21:04 -0400") Message-ID: <87fsfhaw8k.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1olwOE-0005Z6-2i X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56750 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2022 18:05:32 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> Small cleanup to use std::vector iterators rather than raw pointers. Looks good. I think my previous note about hoisting the loop might be wrong after all. Simon> - if (offsetp >= offsets_end Simon> - || *offsetp > origin_child_die->sect_off) Simon> + if (offsets_it == offsets.end () ... like I guess this could trigger. This code is extremely hard to read IMO. Tom From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 5D4B63856DC0 for ; Fri, 21 Oct 2022 18:05:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5D4B63856DC0 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 678AF100C69FC for ; Fri, 21 Oct 2022 18:05:03 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id lwOEo2zFUoMaxlwOFo7Umv; Fri, 21 Oct 2022 18:05:03 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=X4CXlEfe c=1 sm=1 tr=0 ts=6352df4f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=Qawa6l4ZSaYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=o0aJNIb_EADkNXfKqi0A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Ll/dOudeaNeRcBlGWzWrPkbqjtendtEniKSBAzUiJ6s=; b=J7Gf5LqUlV8s8qieh3lsXLjFX4 F54biwLJXomXo1wdL0tcg4w+Ea7WddTIBsi+p0HE+RF194MUcW8m5v8MSG2FGr4lpDpwEzWr0qUwU ed5ctNdhn5ESjcI3WrhC7q4yL; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56750 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1olwOE-0005Z6-2i; Fri, 21 Oct 2022 12:05:02 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH 2/2] gdb: make inherit_abstract_dies use vector iterators References: <20221021132104.1772565-1-simon.marchi@polymtl.ca> <20221021132104.1772565-2-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Fri, 21 Oct 2022 12:04:59 -0600 In-Reply-To: <20221021132104.1772565-2-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Fri, 21 Oct 2022 09:21:04 -0400") Message-ID: <87fsfhaw8k.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1olwOE-0005Z6-2i X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56750 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20221021180459.EtiWGvd7sNbmkENj9cX99leDH6SWFRnP43PAzJYVyzA@z> >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> Small cleanup to use std::vector iterators rather than raw pointers. Looks good. I think my previous note about hoisting the loop might be wrong after all. Simon> - if (offsetp >= offsets_end Simon> - || *offsetp > origin_child_die->sect_off) Simon> + if (offsets_it == offsets.end () ... like I guess this could trigger. This code is extremely hard to read IMO. Tom