From: Tom Tromey <tom@tromey.com>
To: Tsukasa OI via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb: Remove unused extra_lines variable
Date: Thu, 29 Sep 2022 11:22:59 -0600 [thread overview]
Message-ID: <87fsgaxfgs.fsf@tromey.com> (raw)
In-Reply-To: <3090ae2157c8eae596b1bf5989c1853b865fdacf.1664093762.git.research_trasio@irq.a4lg.com> (Tsukasa OI via Gdb-patches's message of "Sun, 25 Sep 2022 08:17:42 +0000")
>>>>> Tsukasa OI via Gdb-patches <gdb-patches@sourceware.org> writes:
> Clang generates a warning if there is a variable that is set but not used
> otherwise ("-Wunused-but-set-variable"). On the default configuration, it
> causes a build failure (unless "--disable-werror" is specified).
> The only extra_lines use in arrange_linetable function is removed on the
> commit 558802e4d1c5dcbd0df7d2c6ef62a6deac247a2f
> ("gdb: change subfile::line_vector to an std::vector"). So, this variable
> should be removed to prevent a build failure.
Thanks, this is ok.
Tom
prev parent reply other threads:[~2022-09-29 17:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 8:17 Tsukasa OI
2022-09-26 9:00 ` Bruno Larsen
2022-09-30 15:50 ` Tsukasa OI
2022-09-29 17:22 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsgaxfgs.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).