From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id CEF0B3857351 for ; Thu, 29 Sep 2022 17:23:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CEF0B3857351 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id DA219100455A6 for ; Thu, 29 Sep 2022 17:23:05 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id dxFYoypuKYID9dxFZo2hQ9; Thu, 29 Sep 2022 17:23:05 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Vu7mv86n c=1 sm=1 tr=0 ts=6335d479 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=xOM3xZuef0cA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=pltyDwRJ8YjM_Kbb8hEA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+4+abBBij3KcHV5R1lxvaQPmZjHzMxXlHXT7fylSJ3Q=; b=jkEix6rSE2d9wE3sKMR9KjzqxI vW+bwjWMvfr8xqXHz+kj0gAOOwbjWuxDWhOwBobpTj+IbNzuHOlt8r3dU/mowR6nhCZBadWrqVge0 0doT0u69qvhcsKBP8YESt4f2P; Received: from 71-211-160-49.hlrn.qwest.net ([71.211.160.49]:56588 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1odxFY-003Zr9-Cu; Thu, 29 Sep 2022 11:23:04 -0600 From: Tom Tromey To: Tsukasa OI via Gdb-patches Subject: Re: [PATCH] gdb: Remove unused extra_lines variable References: <3090ae2157c8eae596b1bf5989c1853b865fdacf.1664093762.git.research_trasio@irq.a4lg.com> X-Attribution: Tom Date: Thu, 29 Sep 2022 11:22:59 -0600 In-Reply-To: <3090ae2157c8eae596b1bf5989c1853b865fdacf.1664093762.git.research_trasio@irq.a4lg.com> (Tsukasa OI via Gdb-patches's message of "Sun, 25 Sep 2022 08:17:42 +0000") Message-ID: <87fsgaxfgs.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.160.49 X-Source-L: No X-Exim-ID: 1odxFY-003Zr9-Cu X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-160-49.hlrn.qwest.net (murgatroyd) [71.211.160.49]:56588 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2022 17:23:33 -0000 >>>>> Tsukasa OI via Gdb-patches writes: > Clang generates a warning if there is a variable that is set but not used > otherwise ("-Wunused-but-set-variable"). On the default configuration, it > causes a build failure (unless "--disable-werror" is specified). > The only extra_lines use in arrange_linetable function is removed on the > commit 558802e4d1c5dcbd0df7d2c6ef62a6deac247a2f > ("gdb: change subfile::line_vector to an std::vector"). So, this variable > should be removed to prevent a build failure. Thanks, this is ok. Tom