From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2e.google.com (mail-vs1-xe2e.google.com [IPv6:2607:f8b0:4864:20::e2e]) by sourceware.org (Postfix) with ESMTPS id EA13E3858D28 for ; Thu, 18 Aug 2022 11:37:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EA13E3858D28 Received: by mail-vs1-xe2e.google.com with SMTP id q190so1163471vsb.7 for ; Thu, 18 Aug 2022 04:37:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc; bh=c7AGTU2+dIgy2ZxV3yMZnKm0FZ1eBXkOjQPLG2KcLdY=; b=mSmeNrtwcGuLxJbetTqKmfYxRjY87lhBkegYboh8sU/w5z2sRxGgqhyQftUFk1IbOX HnrHJjmdgWbl2XNbWVvnbG1aQ74hJJ1QN2t+4wvTMbshn/oFolXK1QQ34BWhQUnDwanu acjFvXUVUikTxyVMvyHvZ10sxJR657X8lfczYYoSierf28/WAy4VzSCmwGfoHmt+cUv3 9SO/+qIlie1DJDjBMSV9EW9B63Cs1iqeXLe0wbunTEOEeWvVAdZe+OGtLwUQHmfIj1Xo au4NZ7SibiJG/gSriuLodpySizKVCY5vHWcMp6Qy8quyglLcmVb1MMDB6GnaqGdiMDRZ xjig== X-Gm-Message-State: ACgBeo0Mfze3TzKgURI+6Bu+mDfzndXyPVQZbm4e6NB3dXq+HRVw0ZAf pVYp7fO4A+S57QwtPpaAXBOXkm1WrD2RHg== X-Google-Smtp-Source: AA6agR5JjsnQAvhplQ1TdkqHgf/EkyDu1rw2F2VwBcX24XcP1aIEVF03yumLoH9MbZ1N23MjfdrX8g== X-Received: by 2002:a05:6102:1d2:b0:386:7b10:188c with SMTP id s18-20020a05610201d200b003867b10188cmr780990vsq.40.1660822640278; Thu, 18 Aug 2022 04:37:20 -0700 (PDT) Received: from localhost ([2804:14c:8780:89d8:3b79:a6db:9142:5828]) by smtp.gmail.com with ESMTPSA id v186-20020a1fdec3000000b003774da8fd03sm706666vkg.27.2022.08.18.04.37.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Aug 2022 04:37:19 -0700 (PDT) References: <20220805004648.111358-1-thiago.bauermann@linaro.org> <20220805004648.111358-3-thiago.bauermann@linaro.org> <87o7wynyet.fsf@linaro.org> <87mtc24mzz.fsf@linaro.org> <71903004-a93e-d879-6bd6-7e4c9e9c1561@arm.com> User-agent: mu4e 1.8.8; emacs 28.1 From: Thiago Jung Bauermann To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/2] gdb/testsuite: Add test for AArch64 Scalable Vector Extension In-reply-to: <71903004-a93e-d879-6bd6-7e4c9e9c1561@arm.com> Date: Thu, 18 Aug 2022 11:37:17 +0000 Message-ID: <87fsht4wb6.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2022 11:37:23 -0000 Hi Luis, Luis Machado writes: > On 8/17/22 21:46, Thiago Jung Bauermann wrote: >> Hello, >> Thiago Jung Bauermann writes: >> >>> Luis Machado writes: >>> >>>> This looks good to me overall. I'd be more comfortable with someone >>>> else approving the generic bits (though they look quite obvious to >>>> me). >>> >>> Ok, hopefully others will agree. :-) >> Ping... Does any other maintainer have an opinion on the generic parts >> of this patch series? >> > > I think this can be pushed, as it is merely moving/sharing a bit of generic testsuite > code. Seems obvious enough. > > Same thing for the other patch cleaning up the once-SPU-specific id field. Nice, thank you! I don't have commit access to the git repository, so would it be possible for you or some other committer to push them for me? I just verified that the patches still apply cleanly. -- Thiago