From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id 998CD3856DCA for ; Fri, 20 May 2022 15:51:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 998CD3856DCA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id 10FCB10047FAF for ; Fri, 20 May 2022 15:51:37 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id s4uenxymhwPf0s4uenYZGL; Fri, 20 May 2022 15:51:37 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=VLgYI/DX c=1 sm=1 tr=0 ts=6287b909 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=oZkIemNP1mAA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=K7iUSVeEt2wBrtwhVO8A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HM7f01TK/Ga0zrG1RaK9RrKJEuSprr5WepVu6muuXYs=; b=kvcHsnpVd4n9PkcAnNyRMMFBKD eNwVQsNfi8UevZ5gXkEiCmakNHy3dFpsghk168yw6yG5VIsHHU/byfEJ+vioo1EepFnzKN4sGvG/9 yfq2hSJ2LYakMYt3DL1vmCCV/; Received: from 71-211-158-194.hlrn.qwest.net ([71.211.158.194]:55814 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ns4ue-003quX-5F; Fri, 20 May 2022 09:51:36 -0600 From: Tom Tromey To: Lancelot SIX via Gdb-patches Cc: Lancelot SIX , lsix@lancelotsix.com Subject: Re: [PATCH v2 2/2] gdb: Simplify psymbol_functions::require_partial_symbols References: <20220519184557.2169347-1-lancelot.six@amd.com> <20220519184557.2169347-3-lancelot.six@amd.com> X-Attribution: Tom Date: Fri, 20 May 2022 09:51:34 -0600 In-Reply-To: <20220519184557.2169347-3-lancelot.six@amd.com> (Lancelot SIX via Gdb-patches's message of "Thu, 19 May 2022 19:45:57 +0100") Message-ID: <87fsl4b3sp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.158.194 X-Source-L: No X-Exim-ID: 1ns4ue-003quX-5F X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-158-194.hlrn.qwest.net (murgatroyd) [71.211.158.194]:55814 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2022 15:51:38 -0000 >>>>> "Lancelot" == Lancelot SIX via Gdb-patches writes: Lancelot> The psymbol_functions class has the require_partial_symbols method which Lancelot> serves this exact purpose. This method does not need to try to read partial Lancelot> symbols anymore, but it can instead assert that any partial symbol have Lancelot> been read at this point. Looks good, thank you. Tom