Re: [PATCH] Error when gdb_is_target_1 is called without running gdb instance

[Tom Tromey <tom@tromey.com>]

>>>>> "Keith" == Keith Seitz via Gdb-patches <gdb-patches@sourceware.org> writes:

Keith> This is a snafu that I encountered while implementing the previous
Keith> patch, which attempted to use gdb_is_target_native.  This proc and
Keith> gdb_is_target_remote both rely on gdb_is_target_1, which actually
Keith> cannot be called without gdb already running.

Keith> This patch adds appropriate warning comments to these procs and
Keith> causes gdb_is_target_1 to issue a Tcl error if it is called without a
Keith> gdb instance already running.  This should prevent unwitting callers
Keith> from using this at the wrong time.

Looks good.

This is one thing I really like about the mythical internal AdaCore test
suite: in it, when you start gdb, you get an object back, and so
something like this would be a method on the object -- impossible to
call without it.

Tom