public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Reduce use of unfiltered output in Darwin code
Date: Fri, 07 Jan 2022 15:13:10 -0700	[thread overview]
Message-ID: <87fspznqix.fsf@tromey.com> (raw)
In-Reply-To: <20220107120149.GB622389@redhat.com> (Andrew Burgess's message of "Fri, 7 Jan 2022 12:01:49 +0000")

Andrew> I'm tempted to suggest that all of the places where we now write to
Andrew> gdb_stderr should be replaced with calls to warning instead.

I'll do that.

Andrew> Also, you have some trailing whitespace (which I only notice because
Andrew> 'git am' tells me, not because I go hunting for such things), I've
Andrew> marked the locations below.

Thanks, I'll fix these.

Tom

  reply	other threads:[~2022-01-07 22:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-06 16:13 Tom Tromey
2022-01-07 12:01 ` Andrew Burgess
2022-01-07 22:13   ` Tom Tromey [this message]
2022-01-08 16:36   ` Tom Tromey
2022-01-09 18:00     ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fspznqix.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).