From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway23.websitewelcome.com (gateway23.websitewelcome.com [192.185.50.129]) by sourceware.org (Postfix) with ESMTPS id 3785D3858C27 for ; Wed, 27 Oct 2021 20:40:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3785D3858C27 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway23.websitewelcome.com (Postfix) with ESMTP id D132E8D62 for ; Wed, 27 Oct 2021 15:39:59 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id fpiJmZaAKglrtfpiJmZWI0; Wed, 27 Oct 2021 15:39:59 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FLEtkTfUwcU5bppPEHZ5lbMk0EY2Wl7OjhWbeaT16Ac=; b=ZufVksDT0ef7r8FIXvyMZtsM2r RFidoN737WWJFvJmB6uIdIudwTlf7/UrldozEP7ANsBPp7+BjUItrmhTng7grDPghYrtHPoA4QsoP XSRT7wc6SSnv1NxT4aOlZK20Y; Received: from 174-16-0-219.hlrn.qwest.net ([174.16.0.219]:54102 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mfpiJ-001BKg-F6; Wed, 27 Oct 2021 14:39:59 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4/4] gdb/python: move styling support to gdb.styling References: <3bdf0af2d6164825ced046689832638c27d90c7f.1635241044.git.andrew.burgess@embecosm.com> X-Attribution: Tom Date: Wed, 27 Oct 2021 14:39:58 -0600 In-Reply-To: <3bdf0af2d6164825ced046689832638c27d90c7f.1635241044.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Tue, 26 Oct 2021 10:37:59 +0100") Message-ID: <87fssmnqw1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.0.219 X-Source-L: No X-Exim-ID: 1mfpiJ-001BKg-F6 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-0-219.hlrn.qwest.net (murgatroyd) [174.16.0.219]:54102 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Oct 2021 20:40:01 -0000 >>>>> "Andrew" == Andrew Burgess writes: Andrew> This commit moves the two Python functions that are used for styling Andrew> into a new module, gdb.styling, there's then a small update in Andrew> python.c so GDB can find the functions in their new location. Looks reasonable to me. Andrew> Still, despite these functions never having been part of a documented Andrew> API, it is possible that a user out there has overridden these to, in Andrew> some way, customize how GDB performs styling. Moving the function as Andrew> I propose in this patch could break things for that user, however, Andrew> fixing this breakage is trivial, and, as these functions were never Andrew> documented, I don't think we should be obliged to not break user code Andrew> that relies on them. I agree, we should only be constrained to the documented API. Tom