From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail03.asahi-net.or.jp (mail03.asahi-net.or.jp [202.224.55.15]) by sourceware.org (Postfix) with ESMTP id 393D4385BF9C for ; Sun, 23 May 2021 13:42:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 393D4385BF9C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=users.sourceforge.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=ysato@users.sourceforge.jp Received: from sakura.ysato.name (ik1-413-38519.vs.sakura.ne.jp [153.127.30.23]) (Authenticated sender: PQ4Y-STU) by mail03.asahi-net.or.jp (Postfix) with ESMTPA id F2D92362ED; Sun, 23 May 2021 22:42:37 +0900 (JST) Received: from yo-satoh-debian.ysato.ml (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by sakura.ysato.name (Postfix) with ESMTPSA id 4D6201C0015; Sun, 23 May 2021 22:42:37 +0900 (JST) Date: Sun, 23 May 2021 22:42:36 +0900 Message-ID: <87fsyd7eib.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Yoshinori Sato , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] sim: h8300 Fixed different behavior in preinc/predec. In-Reply-To: References: <20210521141655.68398-1-ysato@users.sourceforge.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/27 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_SOFTFAIL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 May 2021 13:42:42 -0000 On Sat, 22 May 2021 07:41:32 +0900, Mike Frysinger wrote: > > On 21 May 2021 23:16, Yoshinori Sato wrote: > > Fixed some addressing modes not working properly on the h8300. > > I have confirmed in the test case that the result is > > the same as the actual CPU. > > are there testcases that cover this behavior ? if not, can you add some ? Yes. 2/2 changes include this case. > > --- a/sim/h8300/compile.c > > +++ b/sim/h8300/compile.c > > @@ -1098,6 +1098,35 @@ decode (SIM_DESC sd, int addr, unsigned char *data, decoded_inst *dst) > > /* End of Processing for system calls. */ > > } > > > > + /* Use same register is specified for source > > + and destination. > > + the value of source will be the value after > > "The" > > > + address calculation. */ > > two spaces after . > > > + if (OP_KIND(dst->opcode) != O_CMP && > > + OP_KIND(dst->src.type) == OP_REG && > > + (dst->src.reg & 7) == dst->dst.reg) { > > + switch (OP_KIND(dst->dst.type)) > > + { > > + case OP_POSTDEC: > > + dst->src.type = X(OP_REG_DEC, > > + OP_SIZE(dst->dst.type)); > > should put a space before the ( in all these > -mike OK. I will fix. Thanks. -- Yosinori Sato