From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey <tromey@adacore.com>
Cc: Andrew Burgess <andrew.burgess@embecosm.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH 3/4] Return a vector from ada_lookup_symbol_list
Date: Wed, 03 Mar 2021 12:04:13 -0700 [thread overview]
Message-ID: <87ft1c12ky.fsf@tromey.com> (raw)
In-Reply-To: <87tuptb64r.fsf@tromey.com> (Tom Tromey's message of "Tue, 02 Mar 2021 14:25:08 -0700")
Andrew> Could you clear up the trailing white space here please?
Tom> [... many more comments ...]
Tom> Oops, I totally neglected this review.
Tom> Sorry about that. I will fix it up tomorrow.
I'm about to send it, and check it in. Sorry about that.
Tom
next prev parent reply other threads:[~2021-03-03 19:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 18:04 [PATCH 0/4] Minor C++-ifications for Ada Tom Tromey
2021-02-18 18:04 ` [PATCH 1/4] Use new for ada_symbol_cache Tom Tromey
2021-02-19 17:47 ` Andrew Burgess
2021-02-18 18:04 ` [PATCH 2/4] Simplify resolve_subexp by using C++ algorithms Tom Tromey
2021-02-19 17:55 ` Andrew Burgess
2021-02-19 17:57 ` Andrew Burgess
2021-02-18 18:04 ` [PATCH 3/4] Return a vector from ada_lookup_symbol_list Tom Tromey
2021-02-19 19:53 ` Andrew Burgess
2021-03-02 21:25 ` Tom Tromey
2021-03-03 19:04 ` Tom Tromey [this message]
2021-02-18 18:04 ` [PATCH 4/4] Use std::string rather than grow_vect Tom Tromey
2021-02-19 20:02 ` Andrew Burgess
2021-03-02 19:58 ` [PATCH 0/4] Minor C++-ifications for Ada Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft1c12ky.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).