From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.144.96]) by sourceware.org (Postfix) with ESMTPS id CBAC43865470 for ; Sat, 6 Feb 2021 19:38:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CBAC43865470 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 59B3311DB0 for ; Sat, 6 Feb 2021 13:38:57 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 8TQ1l5OhGiQiZ8TQ1lUcIm; Sat, 06 Feb 2021 13:38:57 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=F1jt3O88tJfHL60SEgullF3/4MboGtx1sMVr/dAMgcc=; b=Re5b8BcZlff4uVjwGuGT+UOSmx t1O/IpLGUr9QZWLz0fKMb2rqHbbhwzAy1rBHgF/JtWOwkkPhAFS7UfWT4jXmUdKsAnUe+R2c9LRx9 llEQ37bbgz+/3WwkivcDy+qSF; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:35854 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l8TQ0-002XUz-Rv; Sat, 06 Feb 2021 12:38:56 -0700 From: Tom Tromey To: Andrew Burgess Cc: Hannes Domani , Tom Tromey , "gdb-patches@sourceware.org" Subject: Re: [PATCH 2/4] Return true in TuiWindow.is_valid only if TUI is enabled References: <20201229170227.821-1-ssbssa@yahoo.de> <20201229170227.821-2-ssbssa@yahoo.de> <20210115164811.GK265215@embecosm.com> <20210117113102.GM265215@embecosm.com> <2060671008.4946685.1610889581434@mail.yahoo.com> <20210123175442.GC265215@embecosm.com> <20210123175551.GD265215@embecosm.com> X-Attribution: Tom Date: Sat, 06 Feb 2021 12:38:56 -0700 In-Reply-To: <20210123175551.GD265215@embecosm.com> (Andrew Burgess's message of "Sat, 23 Jan 2021 17:55:51 +0000") Message-ID: <87ft29x9yn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1l8TQ0-002XUz-Rv X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (localhost.localdomain) [97.122.91.54]:35854 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3026.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Feb 2021 19:38:59 -0000 >>>>> "Andrew" == Andrew Burgess writes: Andrew> gdb/ChangeLog: Andrew> * python/py-tui.c (gdbpy_tui_window) : New member Andrew> function. Andrew> (REQUIRE_WINDOW): Call is_valid member function. Andrew> (REQUIRE_WINDOW_FOR_SETTER): New define. Andrew> (gdbpy_tui_is_valid): Call is_valid member function. Andrew> (gdbpy_tui_set_title): Remove duplicate error checking, call Andrew> REQUIRE_WINDOW_FOR_SETTER instead. Andrew> * tui/tui-data.h (struct tui_win_info) : Check Andrew> tui_active too. Andrew> * tui/tui-layout.c (tui_apply_current_layout): Add an assert. Andrew> * tui/tui.c (tui_enable): Move setting of tui_active earlier in Andrew> the function. Hi. Thanks for the patch. I really thought I had covered this scenario somehow, but I guess not! Oops, sorry about that. Maybe I was thinking that tui disable would destory the windows. Or maybe I planned to do that and then never did. I don't recall any more. Andrew> - if (win->window == nullptr) Andrew> - { Andrew> - PyErr_Format (PyExc_RuntimeError, _("TUI window is invalid.")); Andrew> - return -1; Andrew> - } Andrew> - Andrew> - if (win->window == nullptr) Andrew> - { Andrew> - PyErr_Format (PyExc_TypeError, _("Cannot delete \"title\" attribute.")); Andrew> - return -1; Andrew> - } This second 'if' has the same condition. It's actually a latent bug, as the code should read: if (newvalue == nullptr) ... and then the "if" should remain, rather than being deleted by this patch. I think the patch is ok with this tweak. Tom