From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.143.36]) by sourceware.org (Postfix) with ESMTPS id D554E389365C for ; Fri, 24 Apr 2020 20:50:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D554E389365C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 2C3A054EC2C for ; Fri, 24 Apr 2020 15:50:01 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id S5GrjrLnUAGTXS5GrjAich; Fri, 24 Apr 2020 15:50:01 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SyQXpw9N6Wp9O1DzgqfOAZYfntd9EW+8IrvdeWjtJWI=; b=YxBAcIS/+XNKeOjH/n7iDNbB5C eAXDbW37orqtaPgOgn9athtmKqyKWOFSPmO1v3UxjaEnIf0LTL7ZZChEczmjpVFQQozDWUHik4QLd HcYGFBhG3h4lmeO+zj29myjJY; Received: from 184-96-229-138.hlrn.qwest.net ([184.96.229.138]:52964 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jS5Gq-001vIc-U4; Fri, 24 Apr 2020 14:50:01 -0600 From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 08/10] Use the linkage name if it exists References: <20200325200715.12947-1-tom@tromey.com> <20200325200715.12947-9-tom@tromey.com> <08f5f9ed-49d8-e8f3-c186-52c91c496f14@suse.de> X-Attribution: Tom Date: Fri, 24 Apr 2020 14:50:00 -0600 In-Reply-To: <08f5f9ed-49d8-e8f3-c186-52c91c496f14@suse.de> (Tom de Vries's message of "Fri, 24 Apr 2020 20:09:05 +0200") Message-ID: <87ftcszk07.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 184.96.229.138 X-Source-L: No X-Exim-ID: 1jS5Gq-001vIc-U4 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 184-96-229-138.hlrn.qwest.net (murgatroyd) [184.96.229.138]:52964 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 20:50:05 -0000 >>>>> "Tom" == Tom de Vries writes: Tom> Hmm, one thing that is odd about this test-case is that it constructs a Tom> C language CU, which contains a subprogram with DW_AT_MIPS_linkage_name Tom> attribute with a C++ mangled name. This sounds very familiar. I feel like I patched this at some point but now I don't know where that patch went. Tom> If I update the testcase to use a c++ language CU, the test passes: I think this is the correct thing to do. The main point of the test is to ensure that the linkage name with the wrong form doesn't cause a crash: {DW_AT_MIPS_linkage_name 42 DW_FORM_data1} I suggest you check this in. thanks, Tom