From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112372 invoked by alias); 20 Dec 2019 18:57:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111916 invoked by uid 89); 20 Dec 2019 18:57:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Dec 2019 18:57:19 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 9FFB4A90A for ; Fri, 20 Dec 2019 12:57:17 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id iNSfiOndGqNtviNSfi5eNB; Fri, 20 Dec 2019 12:57:17 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AZUSsNt0jan1hkCN3YRBgzut11Axl2eRl1892LIPhlI=; b=mWmIPVVOfo+V6oebjqJKsTH1m1 znQSkF7+2zx2cpcLu0OVVGD0QIX6TIjKLPYFbf9K8h9/kl67L2GQl+UZepZCRnY05v7PObFXLA62e 96rhLLd9KHE+rswxclqaQKeJQ; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:42634 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iiNSf-000bLg-Ei; Fri, 20 Dec 2019 11:57:17 -0700 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 02/24] Don't rely on inferior_ptid in record_full_wait References: <20191017225026.30496-1-palves@redhat.com> <20191017225026.30496-3-palves@redhat.com> <8736f74pfw.fsf@tromey.com> <683ef49e-3485-aa20-62dd-e43e7019ab41@redhat.com> Date: Fri, 20 Dec 2019 18:57:00 -0000 In-Reply-To: <683ef49e-3485-aa20-62dd-e43e7019ab41@redhat.com> (Pedro Alves's message of "Fri, 20 Dec 2019 17:49:44 +0000") Message-ID: <87fthe7rlf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-12/txt/msg00923.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> How does this sound? Pedro> diff --git i/gdb/target.h w/gdb/target.h Pedro> index 1bb7276673..14a7d3e61f 100644 Pedro> --- i/gdb/target.h Pedro> +++ w/gdb/target.h Pedro> @@ -478,6 +478,13 @@ struct target_ops Pedro> TARGET_DEFAULT_NORETURN (noprocess ()); Pedro> virtual void commit_resume () Pedro> TARGET_DEFAULT_IGNORE (); Pedro> + /* See target_wait's description. Note that implementations of Pedro> + this method must not assume that inferior_ptid on entry is Pedro> + pointing at the thread or inferior that ends up reporting an Pedro> + event. The reported event could be for some other thread in Pedro> + the current inferior or even for a different process of the Pedro> + current target. inferior_ptid may also be null_ptid on Pedro> + entry. */ Pedro> virtual ptid_t wait (ptid_t, struct target_waitstatus *, Pedro> int TARGET_DEBUG_PRINTER (target_debug_print_options)) Pedro> TARGET_DEFAULT_FUNC (default_target_wait); Looks good, thanks. Tom