From: Tom Tromey <tom@tromey.com>
To: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: Re: [PATCH] Rename internal Python functions to start with an underscore
Date: Thu, 15 Aug 2019 19:14:00 -0000 [thread overview]
Message-ID: <87ftm2tf5o.fsf@tromey.com> (raw)
In-Reply-To: <20190815164601.114915-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Thu, 15 Aug 2019 11:46:01 -0500")
>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
Thank you for the patch.
Christian> 2019-08-15 Christian Biesinger <cbiesinger@google.com>
Christian> * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
Christian> leading underscore.
Christian> (GdbOutputErrorFile): Likewise.
Christian> (global scope): Adjust constructor calls to GdbOutput{,Error}File
Christian> accordingly.
Christian> (execute_unwinders): Rename to have a leading underscore.
Christian> (auto_load_packages): Likewise.
Christian> (global scope): Adjust call to auto_load_packages accordingly.
Christian> (GdbSetPythonDirectory): Likewise.
Christian> * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
Christian> instead of execute_unwinders.
Christian> gdb/testsuite/ChangeLog:
Christian> 2019-08-15 Christian Biesinger <cbiesinger@google.com>
Christian> * gdb.python/python.exp: Expect a leading underscore on
Christian> GdbOutput{,Error}File.
I'm maybe mildly concerned that some code out there could be using one
of these, but on the other hand these are all internal. So, I think
this is ok.
Tom
next prev parent reply other threads:[~2019-08-15 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 16:46 Christian Biesinger via gdb-patches
2019-08-15 19:14 ` Tom Tromey [this message]
2019-08-15 19:23 ` Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftm2tf5o.fsf@tromey.com \
--to=tom@tromey.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).