From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57359 invoked by alias); 25 Jul 2018 20:09:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57338 invoked by uid 89); 25 Jul 2018 20:09:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.231) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Jul 2018 20:09:38 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway34.websitewelcome.com (Postfix) with ESMTP id B659B2582D1 for ; Wed, 25 Jul 2018 15:09:36 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id iQ5RfLBzHbXuJiQ5xfRjaT; Wed, 25 Jul 2018 15:09:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/jDzWbSupqpAW1V/gMc1GGQCLEMWnktSdJX76u88KHk=; b=cRmNHqPQclFjO8fQDsn7Z228pu RXAeFyl8Ce5p5y1BeptDmYyROM9FiDSVyAHXeKjP2qdSbgJRV8drPENmixVk+ouBdfKAPKVsoC+Cs +NYqbtk1SMrCvGEeXqoekK/Tj; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:37034 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fiQ5Q-003Svt-Pj; Wed, 25 Jul 2018 15:08:40 -0500 From: Tom Tromey To: Jon Turney Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix Cygwin compilation after target_ops C++ conversion. References: <20180714125203.44168-1-jon.turney@dronecode.org.uk> Date: Wed, 25 Jul 2018 20:09:00 -0000 In-Reply-To: <20180714125203.44168-1-jon.turney@dronecode.org.uk> (Jon Turney's message of "Sat, 14 Jul 2018 13:52:03 +0100") Message-ID: <87fu07yt6f.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-07/txt/msg00710.txt.bz2 >>>>> "Jon" == Jon Turney writes: Jon> After f6ac5f3d "Convert struct target_ops to C++", we need to explicitly use Jon> the global namespace when calling ::close() from windows_nat_target methods, Jon> as that object has a close() method. I didn't see a reply to this. Jon> 2018-07-14 Jon Turney Jon> * windows-nat.c (windows_nat_target::create_inferior): Update to Jon> call close() in global namespace. This is ok. Thank you. Tom