From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [RFA] Remove a cleanup from parse_expression_for_completion
Date: Tue, 20 Feb 2018 05:02:00 -0000 [thread overview]
Message-ID: <87fu5w45jo.fsf@tromey.com> (raw)
In-Reply-To: <87k1v846mh.fsf@tromey.com> (Tom Tromey's message of "Mon, 19 Feb 2018 21:39:18 -0700")
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Tom> Here's an updated patch. Let me know what you think.
Actually, this patch is wrong, and I didn't realize it until this
revision. There was a failure in the buildbot report that I didn't
notice in the noise :(
There is a case in here where the NULL/empty string distinction matters.
So I think we can't use std::string but must instead use
unique_xmalloc_ptr. I'll update the patch.
Tom
next prev parent reply other threads:[~2018-02-20 5:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 23:02 Tom Tromey
2018-02-16 23:27 ` Simon Marchi
2018-02-20 4:39 ` Tom Tromey
2018-02-20 5:02 ` Tom Tromey [this message]
2018-02-20 20:23 ` Tom Tromey
2018-02-21 3:46 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fu5w45jo.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).