From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72643 invoked by alias); 20 Feb 2018 05:02:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72634 invoked by uid 89); 20 Feb 2018 05:02:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.60.19) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Feb 2018 05:02:38 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 9AB18400D8AF7 for ; Mon, 19 Feb 2018 23:02:37 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id o04bexjWtODN4o04bepeWZ; Mon, 19 Feb 2018 23:02:37 -0600 Received: from 174-29-60-18.hlrn.qwest.net ([174.29.60.18]:57788 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eo04b-001Czh-BZ; Mon, 19 Feb 2018 23:02:37 -0600 From: Tom Tromey To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [RFA] Remove a cleanup from parse_expression_for_completion References: <20180216230212.18553-1-tom@tromey.com> <0cbcbff07cb649201177fa01e92327e0@polymtl.ca> <87k1v846mh.fsf@tromey.com> Date: Tue, 20 Feb 2018 05:02:00 -0000 In-Reply-To: <87k1v846mh.fsf@tromey.com> (Tom Tromey's message of "Mon, 19 Feb 2018 21:39:18 -0700") Message-ID: <87fu5w45jo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1eo04b-001Czh-BZ X-Source-Sender: 174-29-60-18.hlrn.qwest.net (bapiya) [174.29.60.18]:57788 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-02/txt/msg00255.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> Here's an updated patch. Let me know what you think. Actually, this patch is wrong, and I didn't realize it until this revision. There was a failure in the buildbot report that I didn't notice in the noise :( There is a case in here where the NULL/empty string distinction matters. So I think we can't use std::string but must instead use unique_xmalloc_ptr. I'll update the patch. Tom