From: Yao Qi <yao@codesourcery.com>
To: Doug Evans <dje@google.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/6] DW attribute macro MACRO_AT_func and MACRO_AT_range
Date: Wed, 05 Nov 2014 01:54:00 -0000 [thread overview]
Message-ID: <87fvdypgap.fsf@codesourcery.com> (raw)
In-Reply-To: <21593.22575.941029.980760@ruffy2.mtv.corp.google.com> (Doug Evans's message of "Tue, 4 Nov 2014 14:50:23 -0800")
Doug Evans <dje@google.com> writes:
Doug,
Thanks for reviewing these patches.
> IWBN if one could add new macros simply by writing a new function.
>
> Can _handle_macro_attribute be rewritten such that
> MACRO_AT_{func,range} are themselves functions?
I don't see any difficulties to implement MACRO_AT_{func,range} as
functions here, but could you tell me why do you prefer to do that?
Is it because they are macros?
After all, in dwarf assembler, all attributes are handled in a single
function, rather than the way that each attribute is handled in the
separate function. MACRO_AT_{func,range}, as special attributes from
the users' point of view, should be handled in a way consistent with
other attributes, IMO.
--
Yao (齐尧)
next prev parent reply other threads:[~2014-11-05 1:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-25 0:17 [PATCH 0/6] Use correct function address in dwarf assembler Yao Qi
2014-10-25 0:18 ` [PATCH 1/6] New proc _handle_attribute Yao Qi
2014-11-04 22:48 ` Doug Evans
2014-10-25 0:18 ` [PATCH 6/6] Fix dw2-ifort-parameter.exp fail with clang Yao Qi
2014-11-04 22:54 ` Doug Evans
2014-10-25 0:18 ` [PATCH 2/6] DW attribute macro MACRO_AT_func and MACRO_AT_range Yao Qi
2014-11-04 22:50 ` Doug Evans
2014-11-05 1:54 ` Yao Qi [this message]
2014-11-07 16:54 ` Doug Evans
2014-11-10 2:04 ` Yao Qi
2014-11-10 19:44 ` Doug Evans
2014-11-11 2:05 ` Yao Qi
2014-11-12 7:01 ` Doug Evans
2014-11-14 1:00 ` Yao Qi
2014-11-04 22:59 ` Doug Evans
2014-10-25 0:18 ` [PATCH 5/6] Fix implptr-optimized-out.exp fail Yao Qi
2014-11-04 22:53 ` Doug Evans
2014-10-25 0:18 ` [PATCH 4/6] Use Dwarf::assemble in implptr-optimized-out.exp Yao Qi
2014-11-04 22:53 ` Doug Evans
2014-10-25 0:18 ` [PATCH 3/6] Get start and end address of main in dwz.exp Yao Qi
2014-11-04 22:51 ` Doug Evans
2014-11-04 23:01 ` [PATCH 0/6] Use correct function address in dwarf assembler Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvdypgap.fsf@codesourcery.com \
--to=yao@codesourcery.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).