From: Tom Tromey <tromey@redhat.com>
To: Keven Boell <keven.boell@intel.com>
Cc: gdb-patches@sourceware.org, sanimir.agovic@intel.com
Subject: Re: [PATCH 1/2] fortran: enable ptype/whatis for user defined types.
Date: Wed, 27 Nov 2013 22:44:00 -0000 [thread overview]
Message-ID: <87fvqhzfdz.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1385460780-4972-2-git-send-email-keven.boell@intel.com> (Keven Boell's message of "Tue, 26 Nov 2013 11:12:59 +0100")
>>>>> "Keven" == Keven Boell <keven.boell@intel.com> writes:
Keven> /* Initialize this in case we *don't* use it in this call; that
Keven> way we can refer to it unconditionally below. */
Keven> memset (&is_a_field_of_this, 0, sizeof (is_a_field_of_this));
I suspect this should be done inside the loop.
Keven> + for (i = 0; i < sizeof(lookup_domains) / sizeof(lookup_domains[0]); ++i)
Spaces before "("s, but also you can use ARRAY_SIZE here instead.
Keven> + sym = lookup_symbol (tmp, expression_context_block,
Keven> + lookup_domains[i],
Keven> + parse_language->la_language == language_cplus
Keven> + ? &is_a_field_of_this : NULL);
Not your problem, but checking for language_cplus here seems like old
copy-and-paste from the C++ parser.
Tom
next prev parent reply other threads:[~2013-11-27 21:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 10:14 [PATCH 0/2] enable ptype/whatis for fortran types/modules Keven Boell
2013-11-26 12:10 ` [PATCH 1/2] fortran: enable ptype/whatis for user defined types Keven Boell
2013-11-27 22:44 ` Tom Tromey [this message]
2013-11-29 13:30 ` Keven Boell
2013-11-26 12:39 ` [PATCH 2/2] fortran: enable ptype/whatis for modules Keven Boell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvqhzfdz.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keven.boell@intel.com \
--cc=sanimir.agovic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).