From: Tom Tromey <tom@tromey.com>
To: "Alexandra Hájková" <ahajkova@khirnov.net>
Cc: gdb-patches@sourceware.org, ahajkova@redhat.com
Subject: Re: [PATCH] Add "error_message+" feature to qSupported
Date: Mon, 29 Apr 2024 08:17:20 -0600 [thread overview]
Message-ID: <87h6fkfe33.fsf@tromey.com> (raw)
In-Reply-To: <20240427085226.2087243-1-ahajkova@khirnov.net> ("Alexandra =?utf-8?B?SMOhamtvdsOhIidz?= message of "Sat, 27 Apr 2024 10:52:26 +0200")
>>>>> Alexandra Hájková <ahajkova@khirnov.net> writes:
> +@item E @var{NN}
> +@var{NN} is errno
I don't think it's correct to say this is errno. For one thing, errno
values aren't interchangeable across systems... but also I don't think
gdb has ever really treated them that way.
> + if (m_features.packet_set_cmd_state (PACKET_accept_error_message)
> + != AUTO_BOOLEAN_FALSE)
> + remote_query_supported_append (&q, "error_message+");
Looking at the existing features, I think it's more normal to use "-" to
separate words, not "_"; or alternatively "camel case". Personally I
perfer "-".
> + if (cs.error_message_supported)
> + strcat (own_buf, ";accept-error-message+");
It seems strange for the response to not just be "error-message+".
Tom
prev parent reply other threads:[~2024-04-29 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 8:52 Alexandra Hájková
2024-04-27 10:03 ` Eli Zaretskii
2024-04-29 14:17 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6fkfe33.fsf@tromey.com \
--to=tom@tromey.com \
--cc=ahajkova@khirnov.net \
--cc=ahajkova@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).