From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id 736673858D35 for ; Mon, 29 Apr 2024 14:17:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 736673858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 736673858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714400246; cv=none; b=LoWnQVim1tmiitoHnoWTOTsjQtFnBAjgSThslYfnCuBBk8aDOMws/XP/7VASD0fuDZV15MotMcBcJhEQ6TYxXq9SkNDHf61RBuUEFQELjkrzqIsmVpI6Fu3HwH6s7k/M+K5ryAPTiRdJHqojfck/Oyxl+L+IhZitj6bGPVOSHu4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714400246; c=relaxed/simple; bh=IboaqF4ii+VQM+DUIDNj18m0R85O3lMdifaLnC3r3ps=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=JtARRt8ZBkyrw8WskseK0RaBVcOXg3ejPSf98D1HARdSc2pBO5WzElcHOQvr56bZWg0bC1KdjM9GdF04gRBgZpKYNE+5Sx165zZrt+/FKCR0ixogUIkWDoIHwXrs6ZsBkHHfnjnz8L2a1DD5GssNgtKvK1kIcJE490cDCveG6EM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5002a.ext.cloudfilter.net ([10.0.29.215]) by cmsmtp with ESMTPS id 171FsSzuqs4yT1RopsYdtY; Mon, 29 Apr 2024 14:17:23 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 1RoosR4wOr1If1RopsjzZr; Mon, 29 Apr 2024 14:17:23 +0000 X-Authority-Analysis: v=2.4 cv=BawT0at2 c=1 sm=1 tr=0 ts=662fabf3 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=BG0i4DACAAAA:8 a=TtMAqRgPt8KGfIWcBWMA:9 a=QEXdDO2ut3YA:10 a=rp301PJrIj0Ozt4Nxktk:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BYPHKTZCed/ZeyBLc3mSg8l3AKb05ukuZPyCkEQUwuU=; b=q52r0zcs2O1C8lETvYKoESCMh5 r64r0XYX41iJZeorFl/krOSQQtVquMS42h3ubbxqKA3IhyyGywggk5UWYx01sMy7GsC7Gl261GhlY eUm3QOWzE+RAJ3b3CC1IgH5BQ; Received: from 97-122-86-252.hlrn.qwest.net ([97.122.86.252]:42168 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1s1Roo-000aAC-0u; Mon, 29 Apr 2024 08:17:22 -0600 From: Tom Tromey To: Alexandra =?utf-8?B?SMOhamtvdsOh?= Cc: gdb-patches@sourceware.org, ahajkova@redhat.com Subject: Re: [PATCH] Add "error_message+" feature to qSupported In-Reply-To: <20240427085226.2087243-1-ahajkova@khirnov.net> ("Alexandra =?utf-8?B?SMOhamtvdsOhIidz?= message of "Sat, 27 Apr 2024 10:52:26 +0200") References: <20240427085226.2087243-1-ahajkova@khirnov.net> X-Attribution: Tom Date: Mon, 29 Apr 2024 08:17:20 -0600 Message-ID: <87h6fkfe33.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.86.252 X-Source-L: No X-Exim-ID: 1s1Roo-000aAC-0u X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-86-252.hlrn.qwest.net (murgatroyd) [97.122.86.252]:42168 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLsdRH9RyOsA4KZC0SMFlHo9BBDfmBlQzrU5RUjP+aCDruXQGfVWi/jhBTdt+9Xcj8Jomt3zDwUPXf27J2uIku5ozlc38jiT647RScLQ/cpqkRpaufWb RRDem8Iba5C4O12GibHKy6wJpjpSYhXrefU3FNMccwQJxsoFILVYhsUIjKdSi4ZaPMh/av5eED6S0ikV9jQjxDqZGbMI0Sob1Zs= X-Spam-Status: No, score=-3015.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Alexandra H=C3=A1jkov=C3=A1 writes: > +@item E @var{NN} > +@var{NN} is errno I don't think it's correct to say this is errno. For one thing, errno values aren't interchangeable across systems... but also I don't think gdb has ever really treated them that way. > + if (m_features.packet_set_cmd_state (PACKET_accept_error_message) > + !=3D AUTO_BOOLEAN_FALSE) > + remote_query_supported_append (&q, "error_message+"); Looking at the existing features, I think it's more normal to use "-" to separate words, not "_"; or alternatively "camel case". Personally I perfer "-". > + if (cs.error_message_supported) > + strcat (own_buf, ";accept-error-message+"); It seems strange for the response to not just be "error-message+". Tom