From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id E5299385840D for ; Wed, 24 Apr 2024 16:25:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E5299385840D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E5299385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::430 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713975913; cv=none; b=BJo0oV6A3gCVSiIvAMhsP3pl4q7qxguaT0TEWMcrGK7VNjeCYl/tN1OBKqsQI13yqt6J3al3UCj2I2LDgkVa6HPza4fHNwSU3mxK23wK3uxTTuArFfT1p+qpEKLVXMz3kcR8mYgqVfDAV3Fsm2abVf3tKGRGprd2eKZnBWPK00I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713975913; c=relaxed/simple; bh=3+iTSk+10SICf8BAyPhkPYg9jLC7u2ffbOuPjO8PeKw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=F+QNj2clOGvd5WvXr3JVgiXhbgdU/Dbw9rHjvQQop6oyETAq0jZRSfnaUuDuXhWmry2IC29/1Ieu1BJwZ3o3m+h8GdEpQ1s4AWkK+PjPPytnBMsSUeKlbCN/1PGXH3iEmBlevlrcXOyfv3dNANwgup6tLsLyVK42VpZUUTgwi+w= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-6ecff9df447so99520b3a.1 for ; Wed, 24 Apr 2024 09:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713975910; x=1714580710; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=QZwKbBac7DHXbesSjRdWHyiEr6kpqb5hNIdIfJ5qnc0=; b=f2tc+FtTeTrg50443Z4+Xh9rSO032NuhH6UdVKNM1XLyYaaInSAGNynTTqNlwI11RX jlXa+5RKOeq2Q9cnOY4Hs7+xrUyL0oiSQMjaCAm1QOp2TPGxh/66j0HjbdPBIj9RXQHT WDDCvikraoe6tX/9NTZaYKeNhJ5FaOjSVElIzpo4r9uLaH9yOH4sLXNpXeFkEJv34Iq5 +zm7DMODna49QoBijzFYhwUWwY7MaOWK8zRIHdkvuPlMXWv/TcgFpt2zVLKPJYjbaZ+e cfv0/tHO5Fgz0BV9rlZ/jQKwUXSsE6w02QfqjNmmfb18oZG1mF+HEIpvVkPunvlAUhIM 0VDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713975910; x=1714580710; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QZwKbBac7DHXbesSjRdWHyiEr6kpqb5hNIdIfJ5qnc0=; b=cjBgM/p5N+ox7ERaMXGJkjfI2FEa5mKgx2/fOev/FNZdopOtJhdOKTI/NlNkOYblO5 oqIK3Pqn3dbhPGECbDkWi0ZFd7FF2c40/TkCy3lp3tnnQ1nPggqyy4VPUwLUxhpY9HiX 7pa5uJ6ZZKL6VMoGrt0jR8c0GRDRWXkPZIPhN63BElcvVAhrzQ0Wgi6+VSKwJLJuoiSV QXpNXyexBww4Ekr/0jus5bFkR2R8s4Y3VaniiGvaaUWCZo/GfcuPxXQ6VWYAkhD0ykdW HRwUHjLEfXyJxuFNXpNjfBDPCdjgSetpOng6eDs7VQtE+Wt89/jRBJ6sUkwk/vr8ZNdM EQsQ== X-Gm-Message-State: AOJu0Yzl45s8Djsg6Na4vzl+wySp97REGcosUvXOVovwW32qDYMYx2JP P9+g44dDriSe0RYCZ1n+OnCCNYVYNChusn3UlZa5mv4Sc8XAzQAkKsrgWNkgTvA= X-Google-Smtp-Source: AGHT+IFF0IStYOEPyLLcZXXTVdxy6GMKH5lLmfn4MS2PY7i/vy214oUe+RJIMyO2XMdAez3drbaAaA== X-Received: by 2002:a05:6a20:1586:b0:1a9:d9bb:acdc with SMTP id h6-20020a056a20158600b001a9d9bbacdcmr3446422pzj.28.1713975909759; Wed, 24 Apr 2024 09:25:09 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:b65d:315b:9fcb:d747]) by smtp.gmail.com with ESMTPSA id e16-20020aa79810000000b006ea6ca5295bsm11610958pfl.164.2024.04.24.09.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 09:25:09 -0700 (PDT) From: Thiago Jung Bauermann To: Kevin Buettner Cc: gdb-patches@sourceware.org, Luis Machado Subject: Re: [PATCH v3 1/2] gdb/testsuite: Add libc_has_debug_info require helper In-Reply-To: <20240423100947.3d5692be@f39-zbm-amd> (Kevin Buettner's message of "Tue, 23 Apr 2024 10:09:47 -0700") References: <20240422230700.1173173-1-thiago.bauermann@linaro.org> <20240422230700.1173173-2-thiago.bauermann@linaro.org> <20240423100947.3d5692be@f39-zbm-amd> User-Agent: mu4e 1.12.4; emacs 29.3 Date: Wed, 24 Apr 2024 13:25:07 -0300 Message-ID: <87h6fq3ezg.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Kevin, Kevin Buettner writes: > On Mon, 22 Apr 2024 20:06:59 -0300 > Thiago Jung Bauermann wrote: > >> Factor the test for libc debug info out of gdb.base/relativedebug.exp to >> a new procedure. >> >> Also, change the "info sharedlibrary" test to explicitly detect when >> libc has debug info. >> --- >> >> As mentioned in the cover letter, the new testcase doesn't use this helper >> procedure anymore so this is an optional patch. I think it's a nice >> cleanup, though I didn't find any other testcase that need it so perhaps >> the new helper is not as useful as I imagine it to be. I'm fine with not >> committing this patch. >> >> Changes in v3: >> - Include in test program to avoid error when using clang >> (suggested by Kevin). > > I agree that it's a nice cleanup and I think that it should go in. > > I've retested with CC_FOR_TARGET set to clang and also gcc. It works > for both. > > Approved-by: Kevin Buettner Thank you! Pushed as commit f5ef12c3f1af. -- Thiago