From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [pushed] gdb: fix include for gdb_signal in target/waitstatus.h
Date: Fri, 19 Apr 2024 14:21:29 -0600 [thread overview]
Message-ID: <87h6fxt86u.fsf@tromey.com> (raw)
In-Reply-To: <20240419200856.2291305-1-simon.marchi@polymtl.ca> (Simon Marchi's message of "Fri, 19 Apr 2024 16:08:55 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> diff --git a/gdb/target/waitstatus.h b/gdb/target/waitstatus.h
Simon> index dce1a7f3175e..7d5ad3f97769 100644
Simon> --- a/gdb/target/waitstatus.h
Simon> +++ b/gdb/target/waitstatus.h
Simon> @@ -21,7 +21,7 @@
Simon> #define TARGET_WAITSTATUS_H
Simon> #include "diagnostics.h"
Simon> -#include "gdbsupport/gdb_signals.h"
Simon> +#include "gdb/signals.h"
I think target/ files should not depend on files from gdb, because
gdb/target (and gdb/nat) are also used by gdbserver.
IMO that's a confusing situation and we should probably move those
subdirs to gdbsupport (but not build them there) to make the setup more
clear. If that's possible.
Tom
next prev parent reply other threads:[~2024-04-19 20:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 20:08 Simon Marchi
2024-04-19 20:21 ` Tom Tromey [this message]
2024-04-23 3:18 ` Simon Marchi
2024-04-23 3:30 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6fxt86u.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).