From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 363BA384AB7E for ; Fri, 19 Apr 2024 15:08:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 363BA384AB7E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 363BA384AB7E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713539302; cv=none; b=Z/FseISAZ17q8Z0EUHmbr+y6w1e0YpNC74UdrMhBSuFmXdTxKDhtO8Sb3hjUKRB0otun6zu6LNeBO2crRfHu8bXsblv5V6tNSFXYdIYHxA/6l3QilwlLOXGRTCNQM3LLCUV4WX+8QWwGAu9xgkruAvjlUNocf/Mcpxlox+RpNsg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713539302; c=relaxed/simple; bh=ovrIZdpPylHW3M7fp/XuWF2zs2gD0fjlZbjhMg7AQ9Q=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=L4YzWEqGo3UkjsZizeiEaqCuQyc2AFbW0l5B6aegXl8YJslFR9ajlgwhl1IvTeyg4i8Qy7l79M70hgVd9vcR9wBu8+StvXIgY9I+hi2SHrvnwWbShrdig7LLGCCF5sqSQYKZF51RaRHW6jnI8IsGsNucYN2Ix3pn9O/oe9s6dck= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5003a.ext.cloudfilter.net ([10.0.29.159]) by cmsmtp with ESMTPS id x8wrrL7Rfl9dRxpqZrY4Rl; Fri, 19 Apr 2024 15:08:15 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xpqZrglTDsT9BxpqZrdXzy; Fri, 19 Apr 2024 15:08:15 +0000 X-Authority-Analysis: v=2.4 cv=LIutQ4W9 c=1 sm=1 tr=0 ts=662288df a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=xrKq8BdPAAAA:8 a=hpxNhRaK5KcSeFdY2AQA:9 a=QEXdDO2ut3YA:10 a=XMSe_M5rEsREOkcl5Ev-:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=tC/DhsgMBBbHcNZMJw0zfFsTOgkge8nfjowpCaHT5dw=; b=xF81UTh/0YZdxppa5SzX4UCgkz TUc4LkuqPWn5b6cHhWyV1lkJ1Aovb/mr7LggfuAMgZsD28bV+MEa1+xP+ef3j9mhj3gEKZVGRXMpu 09omLM2eA8RjWRgjmdIiZ6GTo; Received: from 97-122-86-252.hlrn.qwest.net ([97.122.86.252]:50980 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rxpqY-000DgT-2I; Fri, 19 Apr 2024 09:08:14 -0600 From: Tom Tromey To: Moritz =?utf-8?Q?Str=C3=BCbe?= Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Nios2, gdb: Adjust to new coredump format References: <20240419103922.3621961-1-moritz.struebe@siemens-energy.com> X-Attribution: Tom Date: Fri, 19 Apr 2024 09:08:14 -0600 In-Reply-To: ("Moritz =?utf-8?Q?Str=C3=BCbe=22's?= message of "Fri, 19 Apr 2024 12:39:22 +0200") Message-ID: <87h6fxxue9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.86.252 X-Source-L: No X-Exim-ID: 1rxpqY-000DgT-2I X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-86-252.hlrn.qwest.net (murgatroyd) [97.122.86.252]:50980 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJJHcmshDrcj+vLqwIpkAYa1P6K4Z3/3Wcbt2vT4nOo3QvaV7Pse+86QlsfrnY6jWKdPTc9/JP5OjIR0Mxkt4ylZ50fCyXa1SkOIDwHNm8guVj1/fIYf /U5qitxZfVjrQpY4pyszheXTGbX5cwPmjwOaNc8ffS+Hwwwo55+5Ge0P1/EBaowxoCdI+U/WAajXT97SwA9KRpDMzukRt1ysNS0= X-Spam-Status: No, score=-3015.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Moritz" =3D=3D Moritz Str=C3=BCbe writes: Thank you for the patch. Moritz> Current kernels create their coredumps using ptrace. Adjust to this= new Moritz> format. Is there any need to support old coredumps as well; and if not, why not? Moritz> +/* Registers not set by dump */ Moritz> +static std::set notsetregs =3D {0, 24, 25, 30}; Should be const. Moritz> /* Implement the supply_regset hook for core files. */ Moritz> - Moritz> static void Spurious change. Moritz> + // If regno is 0 dump all registers Moritz> + if(regnum > 0 ){ Moritz> + regcache->raw_supply (regnum, gregs + 4 * regnum); Moritz> + } else { gdb doesn't use '//' comments and also uses a different formatting style. thanks, Tom