From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 2E02C3858437 for ; Thu, 22 Feb 2024 15:07:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2E02C3858437 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2E02C3858437 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708614439; cv=none; b=u78N4Q4TvRhnlor6JMIsUvAHzXKwKerMvdjbGXKWRAHiC3Dig26yoqwvKeIGuY3hXi/G7gY9VfK1pX43OAgDdmu5dHx2eRYcHhnDULmnyqOoieIbsBHjx/vAfJ3t4AGYtUSKEClYaCYFJ8yVhJWP9RNyr/ox/HjSjCukRJ0Tg/I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708614439; c=relaxed/simple; bh=76/sMT5xxc6LZzV7vxjIigaycTXG3X2fB5k8DRnW6iA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=HUQ1M74hIJeJo5DUB7snzPx7fwEGFtITY4lMDe5rB2XBkURdN7Jkp1KhYXq8LLgX3QNhlChH988x/Ghiopd60c7VYtRZxDrW+YvIPjL3cclBrFuv28XvmDslR8tfjM8orx8jQ3bi5PhMUFusUoewUuv3U4qiX6uPgYpHoGmQ9xo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6005a.ext.cloudfilter.net ([10.0.30.201]) by cmsmtp with ESMTPS id d4Lurk3CDrh9zdAfLruoiT; Thu, 22 Feb 2024 15:07:15 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id dAfKrtr3JJNnbdAfKrwMeS; Thu, 22 Feb 2024 15:07:14 +0000 X-Authority-Analysis: v=2.4 cv=P848hDAu c=1 sm=1 tr=0 ts=65d76322 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=k7vzHIieQBIA:10 a=Qbun_eYptAEA:10 a=BAVaUKH4Ldme9PIvDAEA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=76/sMT5xxc6LZzV7vxjIigaycTXG3X2fB5k8DRnW6iA=; b=xIyuDsY1oop/G0Oa4xM0nXRqS/ J2aj7Nth9jNE4SYnlll2kZpnWTIQPNmnojFXAJd7O/AFtlpvPrPl3Zv7aTYprahXQieQoMZ+p1C+2 eXkXDFlESFqLlG5euf0wnBiVU; Received: from 71-211-170-195.hlrn.qwest.net ([71.211.170.195]:48350 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rdAfK-0008Tl-02; Thu, 22 Feb 2024 08:07:14 -0700 From: Tom Tromey To: Tom de Vries Cc: Simon Marchi , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/tui] Factor out tui_noscroll_window et al References: <20231112150601.25484-1-tdevries@suse.de> <87r0kttwba.fsf@tromey.com> <24af4ea8-5426-4ce4-b1c5-12858b38a952@simark.ca> <549c2044-4ec2-4072-a554-6a66e7ddee1d@suse.de> <668e8103-04e8-4ae1-934a-e64f6fd4dc40@suse.de> X-Attribution: Tom Date: Thu, 22 Feb 2024 08:07:12 -0700 In-Reply-To: <668e8103-04e8-4ae1-934a-e64f6fd4dc40@suse.de> (Tom de Vries's message of "Thu, 22 Feb 2024 14:13:21 +0100") Message-ID: <87h6i0zgf3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.170.195 X-Source-L: No X-Exim-ID: 1rdAfK-0008Tl-02 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-170-195.hlrn.qwest.net (murgatroyd) [71.211.170.195]:48350 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOXznp2Fe3QlcgTZaXnrJtvEni7R53JRDcCEqFxvFdqz6TLHAa2tWo7/SvDInIjWp1zb/bYch3uS/2e6LOijqCXPhmhFOqB4TBjoEXQP075V/Enutx/P kRoGqDdAsl6r7i4Z9P8ZOapidW/Uhnu8RxNxQ6x5QS+HoExf/CiAgt5v2xubSDyXW72KFhz6ML6lm1UvbG8GA46ps6w2h58BB08= X-Spam-Status: No, score=-3016.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> It catches the problem at build time for TUI_STATUS_WIN and Tom> TUI_CMD_WIN, but not for the other 3. Those don't have a problem because they don't use virtual inheritance. The problem comes from any class using one of the mixins like: struct tui_always_visible_window : public virtual tui_win_info thanks, Tom