From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by sourceware.org (Postfix) with ESMTPS id AB8C13858401 for ; Tue, 2 Jan 2024 17:00:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AB8C13858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AB8C13858401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1036 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704214809; cv=none; b=QIacfuDaOVyhyPPK7VR+11sbt8PG8cxz0hVxNbWKtWQdOHpOfiB+zvDpc7iruW+5dXRdY03aMWpBgEZCMH2r8benp1uQhGEEanRwv+Tnt527YKLAw7TMcUKYngrd2dB7GQlE+Fb4DVSp1tgzxE6YWIcDfMESiWGAJj+xhEwTXKE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704214809; c=relaxed/simple; bh=TOABZqDUHJGntEr5n68m6FbbuGV06VA0ngiirr/JfOk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=bOZQ+Dtb4qOPg4/cq5vnPcuh8JKdaiahk+tZRpE9HKWIjMxommr0CjXbVP0PRICpjvSWO4Vph/Le3ZiAtBBRNBuhdhhQPD6L0YYfa2gTl7rYasdxJuAm/LxPNKnm+XCrtQZJfmXWlxN9vJEzyddHDcP7O3ay9P0YPb0iBKleX0E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-28b400f08a4so7420287a91.1 for ; Tue, 02 Jan 2024 09:00:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704214803; x=1704819603; darn=sourceware.org; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=itfpeMr/AoBpYQlGmFXkN7ziChRh6WccYixjQwb2cVY=; b=ztDx/W3Uk3EdRGi9LAf6ZqGmjQdraqPDdowCXlukVuBEeBEhRT6aIvVMS9mXPxgN1+ cUuAWfZ2QARq9M71dj2pV1RU4Ef+JG1m23jffihW6K1q6I/pLzg9TEVrmQmyvdijkQYA U7evuOHu27rqXnJ/SrDDpy8VWBdBiqMwG/cGU8jStUAjf1kXslWsCQQvwwkJqOaJ3gN0 pi0s5whJ5w0qqqwuG8DCEgeOFR7DGZw9X1F8M49PQZHU5qiyWdBSPq0XpTBk961op6v4 IRXIfWweS4Ldjs1oq73Z4EUKKqv7YccXD9XYupck0gIp3FgHWB9hV2ELY7DzPM9JrWWr 9uMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704214803; x=1704819603; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=itfpeMr/AoBpYQlGmFXkN7ziChRh6WccYixjQwb2cVY=; b=e/DhAqOWSWh+x63yaI6WJ8fUOzM8RILkeA/fieVsQwujKtqG9beUM/FJijMAT2Pgiy 068iKoKXlx97ZnGDFpvyUs5I/u2ZZUBls+BnD15HXg/ak1JGDq47H5eQI8D02QGIo+rM uIE3Ww5pe18op3jFLKPdLW4nZRGR1ayPr407MoYKCNHA3Xhq7mTD7jQz9kgKEt0u2lN8 a+SK2vl63tpVJZekXCVgXzUaiYdaoRqK71eKjT292h62wnQmA8x6VfpQZikJCwuotEnB rZ5Xx9prX8HLQ7g1TPCv7ANYQ0L8RKOiyc7muaQjDFCdQRv7XDlROjrdVBKtKPJ5Za+n w4AQ== X-Gm-Message-State: AOJu0Ywv7UqyuYHbnPW4rREjDxRID6U50zmggqnceWyUJDvoQEWHHOMO 1bMAStI6J/8IwRc9nKmaPLkKytOjHroZWVzLL/zDCP8sAvA= X-Google-Smtp-Source: AGHT+IGsxedfl5MQvoK4xXvWtawjbEoa9l0dClec6koif6VQHPflSrQevVbsfaDwTcUvME5qTDz11A== X-Received: by 2002:a17:90a:7e8d:b0:28b:e124:1b00 with SMTP id j13-20020a17090a7e8d00b0028be1241b00mr8770916pjl.4.1704214803648; Tue, 02 Jan 2024 09:00:03 -0800 (PST) Received: from localhost ([2804:14d:7e39:8470:1fb8:4182:3352:307e]) by smtp.gmail.com with ESMTPSA id sh18-20020a17090b525200b0028ae9cb6ce0sm27545591pjb.6.2024.01.02.09.00.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jan 2024 09:00:03 -0800 (PST) References: <20231128150121.23760-1-tdevries@suse.de> User-agent: mu4e 1.10.8; emacs 29.1 From: Thiago Jung Bauermann To: Tom de Vries Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v2] [gdb] Fix assert in delete_breakpoint In-reply-to: <20231128150121.23760-1-tdevries@suse.de> Date: Tue, 02 Jan 2024 14:00:01 -0300 Message-ID: <87h6jvbrhq.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, Nice patch. As the discussion in v1 shows, QUIT handling has some subtleties, so I don't think a Reviewed-by from me would be very meaningful. I just have one small nit, if you agree with it: Tom de Vries writes: > +scoped_suppress_quit::~scoped_suppress_quit () noexcept(false) > +{ > + suppress_quit_enabled_cnt--; > + gdb_assert (suppress_quit_enabled_cnt >= 0); > + > + if (suppress_quit_enabled_cnt != 0) > + return; > + > + bool tmp_suppress_quit_seen = suppress_quit_seen; > + suppress_quit_seen = false; > + > + if (!tmp_suppress_quit_seen) > + return; Is the tmp variable needed? It confused me a bit and made me think harder to see if it was addressing some concern I wasn't aware of. But I couldn't think of anything. IMHO the code would be more straightforward if written as: if (!suppress_quit_seen) return; suppress_quit_seen = false; > + > + /* A QUIT was suppressed, unsuppress it here. This may throw. */ > + QUIT; > +} -- Thiago