From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 1F5053858D37 for ; Thu, 30 Nov 2023 19:13:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F5053858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1F5053858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701371596; cv=none; b=MairO+SeoZKqWO0VjLnaS6/CMS75/U2zDMQLDCeMb7O4yLwV3LwqXyg3tXBjiOjEqMBoi5Bpuvigx7aYQEiQb8jCb71w5toQQVFF6kEWUa2uvufjWMkJNLmS+ND6f6ZszFOtxX/JcZ6TWYzq8rw6pjnPyGulotwv2atxP9vhcJg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701371596; c=relaxed/simple; bh=C07Ecw0NYxYSu/LRt2rLhtDbrAhubLtlxKrc7QBgcaA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=J1V6TMCrx+vqa3B7HBUvArDt3U2fIhQ3Or7Dhkzk/R/AXz3YD94AgCb2OJEzWh9cON9Jwd7g3cT8xKF6OHAVGfOeoKdFmoWlTStRLwbn4Dh1SsKRXMt0JMviESZNz5viQQyBCT4zNhbc3mx2Um8ARpIf6ZNeeRAyf1y1pYri5WA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6008a.ext.cloudfilter.net ([10.0.30.227]) by cmsmtp with ESMTPS id 8lWAr014iKOkL8mTIrz60m; Thu, 30 Nov 2023 19:13:12 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 8mTIrCW0x0xkr8mTIrcdkC; Thu, 30 Nov 2023 19:13:12 +0000 X-Authority-Analysis: v=2.4 cv=N7U6qkxB c=1 sm=1 tr=0 ts=6568dec8 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=BNY50KLci1gA:10 a=Qbun_eYptAEA:10 a=dzWzf_mpAAAA:8 a=WDgPodsHyis-hPGwRZ4A:9 a=b4DR9a7p2ZdsqdHBznES:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=iXh0tbORkx/QOFVYXSoleA2RXnxQflIBCS0GECeR9iI=; b=iUv6Oji2UxC85sEfdthGQkPmzR 2fOah3IkHuwHg6PqY+GXhmdlFmFtCOqyXDJk3sWDEa9qU/hTT5QXdZozQ3RySn6SD7KdnDc5KAKCK WKQ6q3mHlQRAnsg++XV3+t0sD; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:57396 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1r8mTH-003jnQ-1P; Thu, 30 Nov 2023 12:13:11 -0700 From: Tom Tromey To: Simon Marchi Cc: PATCH@sourceware.org, More@sourceware.org, gdb-patches@sourceware.org, Tom Tromey , John Baldwin , Luis Machado , Pedro Alves Subject: Re: [PATCH v2 1/8] Use C++17 [[fallthrough]] attribute References: <20231121152817.31859-1-tom@tromey.com> <20231121152817.31859-2-tom@tromey.com> <23d042a3-7f2a-4af3-ab8b-0f43dc0f275e@simark.ca> X-Attribution: Tom Date: Thu, 30 Nov 2023 12:13:10 -0700 In-Reply-To: <23d042a3-7f2a-4af3-ab8b-0f43dc0f275e@simark.ca> (Simon Marchi's message of "Thu, 30 Nov 2023 13:03:35 -0500") Message-ID: <87h6l3cawp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1r8mTH-003jnQ-1P X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (murgatroyd) [97.122.77.73]:57396 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfMO4iPRBoVIhEl9kFC273EHVu0MQvvABOQSKk9mERzAhxTWjpd+GpR7eZr0Qec8TMsYe8iz5OueisJvu1PZT9W1xbzEpGOcwRG5ARc2377CGTeq5X745 m9QRcW546vd282hYGAJ9RAFhWmEJt4F0Mz+0UBQ2FKbeG3OrJYh3rMGi7ZAYgyz9HnxRqNgfZEgmLvpz69Uuo9cx4fJL+vG5Ako= X-Spam-Status: No, score=-3023.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: Simon> Are you able to test building on macos? No. Simon> /Users/jenkins/build/workspace/binutils-gdb_master_macosbuild/platform/macos-amd64/target_board/unix/src/binutils-gdb/gdb/dbxread.c:2809:7: error: fallthrough annotation does not directly precede switch label Simon> [[fallthrough]]; Simon> ^ Can you try the appended? thanks, Tom diff --git a/gdb/dbxread.c b/gdb/dbxread.c index 99d9fba96ea..4947a8e8193 100644 --- a/gdb/dbxread.c +++ b/gdb/dbxread.c @@ -2808,7 +2808,6 @@ process_one_symbol (int type, int desc, CORE_ADDR valu, const char *name, unknown_symtype_complaint (hex_string (type)); [[fallthrough]]; - define_a_symbol: /* These symbol types don't need the address field relocated, since it is either unused, or is absolute. */ case N_GSYM: /* Global variable. */ @@ -2820,6 +2819,7 @@ process_one_symbol (int type, int desc, CORE_ADDR valu, const char *name, case N_LSYM: /* Local symbol in stack. */ case N_PSYM: /* Parameter variable. */ case N_LENG: /* Length of preceding symbol type. */ + define_a_symbol: if (name) { int deftype;