Re: [PATCH v3 2/4] gdb, types: Resolve pointer types dynamically

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Hello,

I've been working a bit with dynamic types lately, but I'm not confident
enough to provide a Reviewed-by.

In any case, some small nits. Everything else LGTM FWIW.

Abdul Basit Ijaz via Gdb-patches <gdb-patches@sourceware.org> writes:

> diff --git a/gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp b/gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp
> index 6e4a331eca8..d6b20086c89 100644
> --- a/gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp
> +++ b/gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp
> @@ -154,7 +154,7 @@ gdb_test "print foo.three_ptr.all'length" \
>           " = 3"
>  
>  gdb_test "ptype foo.three_ptr.all" \
> -         " = array \\(<>\\) of integer"
> +    " = array \\(1 \\.\\. 3\\) of integer"

The new indentation level is inconsistent with the rest of the file.
Please preserve the original indentation level.

>  
>  # foo.three_ptr
>  
> @@ -177,7 +177,7 @@ gdb_test "print foo.three_ptr'length" \
>           " = 3"
>  
>  gdb_test "ptype foo.three_ptr" \
> -         " = access array \\(<>\\) of integer"
> +    " = access array \\(1 \\.\\. 3\\) of integer"

Ditto for the other changes in this file.

> diff --git a/gdb/testsuite/gdb.fortran/pointers.exp b/gdb/testsuite/gdb.fortran/pointers.exp
> new file mode 100644
> index 00000000000..ca2195bbfe6
> --- /dev/null
> +++ b/gdb/testsuite/gdb.fortran/pointers.exp
> @@ -0,0 +1,115 @@
> +# Copyright 2016-2023 Free Software Foundation, Inc.

This is a new file. The copyright starts in 2023.

> +
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.

-- 
Thiago