From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by sourceware.org (Postfix) with ESMTPS id A26373858D35 for ; Tue, 3 Oct 2023 00:08:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A26373858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-277504a23a1so230729a91.0 for ; Mon, 02 Oct 2023 17:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696291682; x=1696896482; darn=sourceware.org; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=rauzpVtXveq0LQ595gUMTo0mohTNyrqtENEzeVOieTA=; b=KGv2ENBRjMgbbb03jDboB/EuSuVm/O4h/7dAEhHUZe4BifT+U9dmXaK5wjozI6ODTP tA5j2NrbCLNCU0cPA54/mMQ2bzHhd34aC5EImzlGdxxNhk/vy6f68T94mAjZ+9IM6O3R eBlN0dPxHQYhd/6M8D8MT9PGKRVOqj65zL1aZ2VtH1IgYqnUGg1xSzmjbGu4OGyJQ1bN hiBZkp8hYsh+/Xv+Bn3dyFPuzzGtk6Z5CgVJqQRd1GPHXIOV2Ep66+rCTQQ6hdYBn6pC brPp5mT03lI0Wf/DUPXigvQLp4oIUHrclSwniCE2AHmTmNg9CN/8OsgidH7ChxVyicVi Nj4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696291682; x=1696896482; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rauzpVtXveq0LQ595gUMTo0mohTNyrqtENEzeVOieTA=; b=c2m1r9dRXm+A4FKlmIKgiJlWIdp8YHvTpm8ZgI8HwrfLLoSJcMyqtF7zaTbJ3/3uvW E23c+dbm9cfYsljposvMIEJPsiFF0UstSoxcS76qhJEmLtUp04SsKgq+DrXAe0TyGjiP EiVcMlmeAla7vo1bfsP15vflfu1WwhXE3q4rjdS0cG6Az9TLeDK4daMvc+w1EKpDkv8M zcmvtfbzTOzjRXg/rXZksv5VDSY+ZPEaM5roeZrsLMdVoFP2mBEdkdVyB/z+R3aOkuQ6 0lWhVR2dxLOcvp6VdzlQJ3uI/pW6P75Jg+BznXFCvXjDEU1hdJeu6iHFzBUhCPT9GSgr 6pEA== X-Gm-Message-State: AOJu0Yw+0EXcbz60mBjDuf/A+VMLJe02XcweTvUrpNi6kIEBSfchpV0w nBRuqKVeNL7gBCvm218aBz1U9fX+FFtKwCZeOHI= X-Google-Smtp-Source: AGHT+IFEhNjIJRdVYtFMel3jXUsReICPuI3U2/EJN4kXUz/gyf6ISORTEEm3LLz/8kMiNbrtREN5hw== X-Received: by 2002:a17:90a:4ce6:b0:277:3379:ce04 with SMTP id k93-20020a17090a4ce600b002773379ce04mr1703549pjh.18.1696291682484; Mon, 02 Oct 2023 17:08:02 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:c981:e91d:3861:6298]) by smtp.gmail.com with ESMTPSA id ch23-20020a17090af41700b002790423f66fsm6899209pjb.26.2023.10.02.17.08.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 17:08:01 -0700 (PDT) References: <20230904222956.15203-1-abdul.b.ijaz@intel.com> <20230904222956.15203-3-abdul.b.ijaz@intel.com> User-agent: mu4e 1.10.7; emacs 29.1 From: Thiago Jung Bauermann To: Abdul Basit Ijaz Cc: simark@simark.ca, tom@tromey.com, gdb-patches@sourceware.org Subject: Re: [PATCH v3 2/4] gdb, types: Resolve pointer types dynamically In-reply-to: <20230904222956.15203-3-abdul.b.ijaz@intel.com> Date: Mon, 02 Oct 2023 21:07:58 -0300 Message-ID: <87h6n8effl.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, I've been working a bit with dynamic types lately, but I'm not confident enough to provide a Reviewed-by. In any case, some small nits. Everything else LGTM FWIW. Abdul Basit Ijaz via Gdb-patches writes: > diff --git a/gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp b/gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp > index 6e4a331eca8..d6b20086c89 100644 > --- a/gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp > +++ b/gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp > @@ -154,7 +154,7 @@ gdb_test "print foo.three_ptr.all'length" \ > " = 3" > > gdb_test "ptype foo.three_ptr.all" \ > - " = array \\(<>\\) of integer" > + " = array \\(1 \\.\\. 3\\) of integer" The new indentation level is inconsistent with the rest of the file. Please preserve the original indentation level. > > # foo.three_ptr > > @@ -177,7 +177,7 @@ gdb_test "print foo.three_ptr'length" \ > " = 3" > > gdb_test "ptype foo.three_ptr" \ > - " = access array \\(<>\\) of integer" > + " = access array \\(1 \\.\\. 3\\) of integer" Ditto for the other changes in this file. > diff --git a/gdb/testsuite/gdb.fortran/pointers.exp b/gdb/testsuite/gdb.fortran/pointers.exp > new file mode 100644 > index 00000000000..ca2195bbfe6 > --- /dev/null > +++ b/gdb/testsuite/gdb.fortran/pointers.exp > @@ -0,0 +1,115 @@ > +# Copyright 2016-2023 Free Software Foundation, Inc. This is a new file. The copyright starts in 2023. > + > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . -- Thiago