From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by sourceware.org (Postfix) with ESMTPS id 18AE03858D32 for ; Mon, 18 Sep 2023 14:20:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 18AE03858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x132.google.com with SMTP id e9e14a558f8ab-34ffcc608d6so892985ab.1 for ; Mon, 18 Sep 2023 07:20:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1695046840; x=1695651640; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZgaNngyTepv6re2PERCbufwRs15adOurMYvXiMXoOSM=; b=W9tsJaptKPs8vIhIhabLaYE9PEdJSUuI6PqlJd8xibvMQIGYupqkfEAddIvQvvEHxp cm4rEoPCzgVezfgXSbEkZosSqAaD2Yl0fM4S1+uFkhanic9mIgp3sUxB/pFMY89to593 R+GolvRUE71wdFRqF11wsiR6OWMcvFdn59gZ0NMubamAjNx24WJtwH7hN6OdlX/Il0u+ /bAxqhg1A4H+s3Y1HGYr7RuJgwn0zn+0hY+VqlSikgrp8U5i0ypuzssSth5Mz9SUQYyA cnmrh9Ig2zwsnicjtUiYwTdVvbg2iFJWh5E6eDMySU6vWyyndZfWcLqhTqNegOrb708o TAXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695046840; x=1695651640; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZgaNngyTepv6re2PERCbufwRs15adOurMYvXiMXoOSM=; b=g76+TzrL2uyjSbx8ottlzQGrL7P9l6UGSlbOQsaLNzGB94ou29+Qwhlvpf/HdmZrlu EMgYe3T65oiUFANmdQ2RP1zzCNk0FS0dFXd+jJVC2/7PjojfUnzked28BuqAn073wU76 cNMIiJPsnQOHlkVf7xRv5H1okypH5MFThrnFL091tG+OvNbbj6LiV4X6YGJs/H+bGHKb lmVlr9ErHrANaOf+Q9Fu9ZGG0DHY+y6KubEcIvFyutRcgYnwho2hzvN3TIWP2nHGI35G O6RUazsEP+TCcdeFdXMGFhLYItMsCwXHn2eFziQVNiFBe8+DNbkZgnhXBnPWS3h5hJjd 4Xtw== X-Gm-Message-State: AOJu0Yzbz/ow2G7TDTI/euc9BajYdAXu/t9F35QfeeLL8kE0abYPQz5X +/KOay3UgOV8wb8MNnLehTiU1w== X-Google-Smtp-Source: AGHT+IF+B6myqiqzIcv5P47vdYbyhiSX5lSQ53oE18giOQbtDSJp5JCXiOObTx7hmN1A6JCozs0TFA== X-Received: by 2002:a05:6e02:ca1:b0:34f:7e2f:b837 with SMTP id 1-20020a056e020ca100b0034f7e2fb837mr8687667ilg.2.1695046840099; Mon, 18 Sep 2023 07:20:40 -0700 (PDT) Received: from murgatroyd (71-211-130-31.hlrn.qwest.net. [71.211.130.31]) by smtp.gmail.com with ESMTPSA id k14-20020a92c9ce000000b0034ff8f837e2sm285446ilq.86.2023.09.18.07.20.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 07:20:39 -0700 (PDT) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] Use gdb::checked_static_cast for watchpoints References: <20230915-watchpoint-casts-v1-0-a4ff35c9644e@adacore.com> <20230915-watchpoint-casts-v1-1-a4ff35c9644e@adacore.com> <1aba9929-690e-448d-b7d7-5cf90604fdad@polymtl.ca> X-Attribution: Tom Date: Mon, 18 Sep 2023 08:20:38 -0600 In-Reply-To: <1aba9929-690e-448d-b7d7-5cf90604fdad@polymtl.ca> (Simon Marchi's message of "Sun, 17 Sep 2023 20:40:33 -0400") Message-ID: <87h6nra7gp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: Simon> Not mandatory, but when doing these refactorings, I find it's a good Simon> time to bring the variable declaration down. And also, get rid of the Simon> struct keyword, if possible. So: Simon> watchpoint *b = gdb::checked_static_cast (bs->breakpoint_at); I made these changes in v2. Tom