From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Filter invalid encodings from Linux thread names
Date: Tue, 12 Sep 2023 10:11:09 -0600 [thread overview]
Message-ID: <87h6nzjrs2.fsf@tromey.com> (raw)
In-Reply-To: <20230717204756.1880945-1-tom@tromey.com> (Tom Tromey's message of "Mon, 17 Jul 2023 14:47:56 -0600")
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Tom> On Linux, a thread can only be 16 bytes (including the trailing \0).
Tom> A user sent in a test case where this causes a truncated UTF-8
Tom> sequence, causing gdbserver to create invalid XML.
Tom> I went back and forth about different ways to solve this, and in the
Tom> end decided to fix it in gdbserver, with the reason being that it
Tom> seems important to generate correct XML for the <thread> response.
Tom> I am not totally sure whether the call to setlocale could have
Tom> unplanned consequences. This is needed, though, for nl_langinfo to
Tom> return the correct result.
Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30618
I'd appreciate comments on this one.
Eventually I guess I'll checked it in, though.
Tom
next prev parent reply other threads:[~2023-09-12 16:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 20:47 Tom Tromey
2023-09-12 16:11 ` Tom Tromey [this message]
2023-11-14 16:01 ` Tom Tromey
2023-11-27 21:01 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6nzjrs2.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).