From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x132.google.com (mail-il1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) by sourceware.org (Postfix) with ESMTPS id 8076A3858033 for ; Thu, 3 Aug 2023 15:36:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8076A3858033 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x132.google.com with SMTP id e9e14a558f8ab-349099fce6dso4028145ab.2 for ; Thu, 03 Aug 2023 08:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1691076966; x=1691681766; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=JUJ6q7G+iMag8TXd0jeWoOdTmiBXX5LCXfmVHWDJzVY=; b=Gab3kebtBPyUR9ka7mySE1pHj7IqdHgKlnwu241ZAumlT7eADVHHNysoJvuMCvKg0x 1jDUZ3kUTB2iS5U9aDeYdjnbTPie1P8nwD7jRYjcZl/YPm5e8jxUN9cxjL0T2yVkznDR aZ8RdIsYB9AWY0cTjKknx/CfG9b4yI2EBFoiEEhUItxW8otToqedxxBj0KuLUgTXH1Ry /WX07b4ljotYcJVqzZX4ZHoXZ9DVbaWhoxYXozlPftdRXY2uccPTOezyLTNSV2KmOoXT Fqa3SY36XjLKRa2Z12siHl7ZKhPA8a8UMZ/GgtCyPjv+vLu7rtDKyyJ+nobdp0C54hkS rmCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691076966; x=1691681766; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JUJ6q7G+iMag8TXd0jeWoOdTmiBXX5LCXfmVHWDJzVY=; b=Vomxv7c2Lfl+uy8e4Z8e/N+A4wCaTTKyfk2/b3wL8bSWC50gu/iPqsCR+SQR9Edtyr xa1OQ0WP356Qp0alnZ5cHirJkSQLj6lsiLh25US+XQdhaKJTL3pGDYS6nUwWqB8qDfzB sHj/W7oxjI0Z2xJg0Cs6xGDND5ku/1S09XbI8X4mDCo8KAtkBgFiNQr4w4T0SwXOUH6e 2qHf6jij3haqn+J2nyutF09H3iZyNCEeTxPNDob098KIYUOpobD3omjBca9MvaundcB5 m/2vfVSulgXC3nPd3c1bWiH/T/o2tqzUs6uY18ENsp2K6Q23OG/3x9fKP3fKgcnDosjB BeOA== X-Gm-Message-State: ABy/qLYdhpbrygOUYV37TJvFa0GrVZVfPC4Ho8cqQwwXMKxjViYHJ1iE IEdwvSUEpEq+2luhgyjDR5wGxA== X-Google-Smtp-Source: APBJJlFoo4Q2UWug93FWI+zz8YHxrXK3uR/aam5ut40WihzDTJWAh/HRv2i0JjPVw1tY1j9WWv8K0g== X-Received: by 2002:a05:6e02:1569:b0:348:76eb:17d9 with SMTP id k9-20020a056e02156900b0034876eb17d9mr21477723ilu.20.1691076966679; Thu, 03 Aug 2023 08:36:06 -0700 (PDT) Received: from murgatroyd (71-211-152-221.hlrn.qwest.net. [71.211.152.221]) by smtp.gmail.com with ESMTPSA id o17-20020a92dad1000000b00345840d442csm49986ilq.66.2023.08.03.08.36.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 08:36:06 -0700 (PDT) From: Tom Tromey To: Alexandra Petlanova Hajkova Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Use frame.name() in FrameDecorator References: <20230801200627.2901739-1-tromey@adacore.com> X-Attribution: Tom Date: Thu, 03 Aug 2023 09:36:04 -0600 In-Reply-To: (Alexandra Petlanova Hajkova's message of "Thu, 3 Aug 2023 15:50:17 +0200") Message-ID: <87h6pgb0kb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Alexandra Petlanova Hajkova writes: >> However, there's a different approach we can take: the code here can >> simply use Frame.name. This handles the PC problem correctly, and >> gets us the information we need. > I tested this for Fedora-Rawhide on ppc64le. I can confirm this causes > no regressions and I can see {"id": 1, "name": "no_debug_info", is > outputted instead of {"id": 1, "name": 268501652. Thank you. I'm going to check this in. Tom