From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by sourceware.org (Postfix) with ESMTPS id 37CC138582AC for ; Fri, 7 Jul 2023 19:57:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 37CC138582AC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-7836272f36eso82777039f.1 for ; Fri, 07 Jul 2023 12:57:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1688759825; x=1691351825; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Mwbpdrx19C2gnhPYXsFru3G6Go1vDi+YiK12MpNDx3o=; b=iFR/Qs54ZuGxcFE2h8k2uBpwLrEL58Irz6vyH2hzQxQL6XYZU1pq4pSTyGPo3GVt0x aMhBDoulyOUcm6ngMh6XnOtyZKgQjsb/icvtbjfcWDEQG3uH3JTOIovZ8zeU+ayE8BsB r516k8SmTct9l4ldkrb7xmCu8e8kGDugwlEXqyLXNARNlEvOiXpfl3gd6AIGM3OUkisI 90iYmtV+wzWCPxd5KhVmOGoKb6jVWWOzH0dQYSh450udmEHTtCt4ew7VbgTXqw/abIM5 lR+BElMGm0Oizad2SAKYO9Re3LX2kG6n5p+QxLwv6QsECdlUPOKlV3MS4E79YYCqnHG/ eL2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688759825; x=1691351825; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Mwbpdrx19C2gnhPYXsFru3G6Go1vDi+YiK12MpNDx3o=; b=J3eaFohIZG50UGtqcH6ZoE4bPydSao/0tTLXnrFQP2O0ZiSIPUCderqB9amaXEyUHW rj+z/T6PmfkI9ZTaGPbho0JVOgnNCbA6m36/B3oCrOt8HOnJpY7SYAcWV8Psf2vxeFnf +vbMp5QI7wOeVz04JDxwLrjv288/cmkiKU1pyms/t58PKuVJZ9FdXRRs7N9UPHuexabR Dm+n9kN973ZwvhOtU2AUYvZBSLMZiMv+L7F9vr554d4u1cml3nPfAWKGEz4cb7r+HxVz 89s0KJrHahx6JHtfI1BT98lzmqkRi/NG/IX0q1cAHVvi49igGolzlu4gJpLaqiVidggm 0vng== X-Gm-Message-State: ABy/qLbpu/jL7Y+kSgAy/MNq2zREj1IgX5zkP+dkeqGxWFVVGZaZS8th yhbmt+q0jX8tHgSyCUhaMmu3SogpE972zPLHQmIVrQ== X-Google-Smtp-Source: APBJJlGUP7xzKdqWEd4BEg0N8+IjxFdBVT72+lrAlSFaxDnD67M0/dIAyR+1IM7ZzkeSdFaTHL+XhQ== X-Received: by 2002:a6b:db07:0:b0:783:5e4e:b785 with SMTP id t7-20020a6bdb07000000b007835e4eb785mr6044764ioc.19.1688759825521; Fri, 07 Jul 2023 12:57:05 -0700 (PDT) Received: from murgatroyd (75-166-135-140.hlrn.qwest.net. [75.166.135.140]) by smtp.gmail.com with ESMTPSA id b8-20020a05663801a800b0042b05c1b702sm1540860jaq.12.2023.07.07.12.57.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 12:57:05 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Fix result of DAP setExpression References: <20230628135610.2695419-1-tromey@adacore.com> X-Attribution: Tom Date: Fri, 07 Jul 2023 13:57:04 -0600 In-Reply-To: <20230628135610.2695419-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Wed, 28 Jun 2023 07:56:10 -0600") Message-ID: <87h6qfsdf3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> A co-worker, Andry, noticed that the DAP setExpression implementation Tom> returned the wrong fields -- it used "result" rather than "value", and Tom> included "memoryReference", which isn't in the spec (an odd oversight, Tom> IMO). Tom> This patch fixes the problems. I'm checking this in. Tom